jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From 黄吉浩 <13651877...@163.com>
Subject How to commit a patch for jmeter?
Date Wed, 22 Oct 2014 14:13:33 GMT

sorry for this basic question, but I looked in jmeter.apache.org and read 'Contribute back
to the community', but didn't find answer.
there is  Bug 56197https://issues.apache.org/bugzilla/show_bug.cgi?id=56197
part of the bug is:

2) The file will not be sent if the UI is on the 'Body Data' tab, even if this tab has no
content.  Simply switching to the Parameters tab causes the file to be included.

I meet this bug in my work either, so I create a patch in eclipse,  I tested it worked, I
think I fixed it.
the patch is as following, But I don't know how to submit this patch to the svn reposity?

Index: src/protocol/http/org/apache/jmeter/protocol/http/config/gui/UrlConfigGui.java
===================================================================
--- src/protocol/http/org/apache/jmeter/protocol/http/config/gui/UrlConfigGui.java	(revision
1633145)
+++ src/protocol/http/org/apache/jmeter/protocol/http/config/gui/UrlConfigGui.java	(working
copy)
@@ -203,9 +203,11 @@
              * On retrival, CRLF is converted back to LF for storage in the text field.
              * See
              */
-            HTTPArgument arg = new HTTPArgument("", text.replaceAll("\n","\r\n"), false);
-            arg.setAlwaysEncoded(false);
-            args.addArgument(arg);
+            if (!text.replaceAll("\n","\r\n").equals("")){ 
+	            HTTPArgument arg = new HTTPArgument("", text.replaceAll("\n","\r\n"), false);
+	            arg.setAlwaysEncoded(false);
+	            args.addArgument(arg);
+            }
         } else {
             args = (Arguments) argsPanel.createTestElement();
             HTTPArgument.convertArgumentsToHTTP(args);
Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message