Return-Path: X-Original-To: apmail-jmeter-dev-archive@minotaur.apache.org Delivered-To: apmail-jmeter-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B90F711B74 for ; Mon, 1 Sep 2014 00:27:26 +0000 (UTC) Received: (qmail 14208 invoked by uid 500); 1 Sep 2014 00:27:26 -0000 Delivered-To: apmail-jmeter-dev-archive@jmeter.apache.org Received: (qmail 14175 invoked by uid 500); 1 Sep 2014 00:27:26 -0000 Mailing-List: contact dev-help@jmeter.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jmeter.apache.org Delivered-To: mailing list dev@jmeter.apache.org Received: (qmail 14163 invoked by uid 99); 1 Sep 2014 00:27:26 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Sep 2014 00:27:26 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of sebbaz@gmail.com designates 209.85.212.178 as permitted sender) Received: from [209.85.212.178] (HELO mail-wi0-f178.google.com) (209.85.212.178) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Sep 2014 00:27:20 +0000 Received: by mail-wi0-f178.google.com with SMTP id r20so5177203wiv.11 for ; Sun, 31 Aug 2014 17:26:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=lVvKdGtNebyMLHOmYRxnKn07q13t7A1LwRiieo5Ktos=; b=EgLHVRXcCAu/peeAGptvY3kUr8faNuP4VRWUHzsFoLZi8sfX9yWxa0+yMY08ERROUF TeL0vcyXt9fDOz0uSq3R5kWapyO3P7Wy9G0c8j/Zw3I93HjZJLFYOwRB0tSLV5eUomHc VLdGZRENTj2VbZ7oPD/1FC0/IgShWHOm/C4Bdotzd47Uoonzr7Sutgq4xEdZme5lV1x1 qLS2SH6Dwqce80aXEWU2NKQ61hZwpykbxTjp3wFctOrM5E6IVlPum9Y8gkRCRcZ7j91Y CabzSVPJcWcPFGLlaS5Xl6/nRJU5QZC825daS7rgjZrNpDScN7HjbR6UGdl9NWLiH9KK rugw== MIME-Version: 1.0 X-Received: by 10.194.77.243 with SMTP id v19mr27971634wjw.18.1409531219747; Sun, 31 Aug 2014 17:26:59 -0700 (PDT) Received: by 10.194.162.231 with HTTP; Sun, 31 Aug 2014 17:26:59 -0700 (PDT) In-Reply-To: References: Date: Mon, 1 Sep 2014 01:26:59 +0100 Message-ID: Subject: Re: Bug 54778 / Cache Manager / Backward compatibilitiy From: sebb To: dev@jmeter.apache.org Content-Type: text/plain; charset=UTF-8 X-Virus-Checked: Checked by ClamAV on apache.org On 30 August 2014 20:17, Philippe Mouawad wrote: > Hello, > I commited in r1621523 a fix for bugzilla 54778. > This fix will change the number of SampleResults that will appear. > Previously, when a resource was found in cache , a SampleResult with empty > content and code 204 was returned. > With the fix null is returned leading to no SampleResult being generated. > > This will change in results the number of subResults of main SampleResult. > > Do you think we should add a property to allow having old behaviour knowing > that previous behaviour was wrong or is it fine this way ? > Tricky one to answer. Probably best to ask this question on the user list, as the users are the ones who will be affected. > Thanks for feedback. > Regards > Philippe M. > @philmdot