Mailing-List: contact dev-help@jmeter.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jmeter.apache.org
Received-SPF: pass (athena.apache.org: domain of philippe.mouawad@gmail.com
 designates 209.85.160.174 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <5426A073.2030307@ya.ru>
References: <542541EC.2020701@ya.ru>
	<CAH9fUpY=uARYrFm-ZZ2m6TOdvVvtHnZE2twCWT7v8mNzVpRs6Q@mail.gmail.com>
	<542567AF.7020103@ya.ru>
	<CAH9fUpYA-88pLAdnaRsB4K3OOT8OXwwQ-nuzyADS8gHj52xMGQ@mail.gmail.com>
	<542698C0.2050504@ya.ru>
	<CAH9fUpY+ZKm5qf=2CGdz8axY59__b92jHzuRdWCWQ8QuhsLLBA@mail.gmail.com>
	<5426A073.2030307@ya.ru>
Date: Sat, 27 Sep 2014 13:36:22 +0200
Message-ID: 
 <CAH9fUpZqfj8vbE-dJQQuteXZGp-AjZOJ52RFu7RM05W5zdhfiw@mail.gmail.com>
Subject: Re: Enable saving thread counts by default?
From: Philippe Mouawad <philippe.mouawad@gmail.com>
To: "dev@jmeter.apache.org" <dev@jmeter.apache.org>
Content-Type: multipart/alternative; boundary=20cf301afbbf6c469f05040a712a

--20cf301afbbf6c469f05040a712a
Content-Type: text/plain; charset=ISO-8859-1

On Sat, Sep 27, 2014 at 1:33 PM, Andrey Pokhilko <apc4@ya.ru> wrote:

> Thanks Philippe,
>
> Now I'm able to see the failure. Do we have bugzilla for the change
> already or should I register one?
>
Create one mentionning the 2 discussions.
Thanks

>
> Andrey Pokhilko
>
> On 09/27/2014 02:16 PM, Philippe Mouawad wrote:
> > Hello,
> > It's because there was an issue in last commit which upgraded serializer
> > version to 2.7.2, one test was failing.
> >
> > Try again now, you will see.
> > Regards
> >
> > On Sat, Sep 27, 2014 at 1:00 PM, Andrey Pokhilko <apc4@ya.ru> wrote:
> >
> >> Hi,
> >>
> >> I took latest trunk from SVN and changed bin/jmeter.properties to have
> >> jmeter.save.saveservice.thread_counts=true
> >>
> >> Then I ran "ant clean download_jars install test". The only error that
> >> showed is:
> >>      [java] There was 1 failure:
> >>      [java] 1)
> >>
> >>
> testMaven(org.apache.jmeter.JMeterVersionTest)junit.framework.ComparisonFailure:
> >> serializer expected:<2.7.[2]> but was:<2.7.[1]>
> >>      [java]     at
> >>
> org.apache.jmeter.JMeterVersionTest.testMaven(JMeterVersionTest.java:182)
> >>      [java]     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> >> Method)
> >>      [java]     at
> >>
> >>
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> >>      [java]     at
> >>
> >>
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> >>      [java]     at
> org.apache.jorphan.test.AllTests.main(AllTests.java:236)
> >>
> >> Which seems to be unrelated to saveservice change. It also appears
> >> without any change to properties.
> >>
> >> So I see no tests failing after the change. Does it mean that we can do
> >> the change right now?
> >>
> >> Andrey Pokhilko
> >>
> >> On 09/26/2014 04:24 PM, UBIK LOAD PACK Support wrote:
> >>> Hi,
> >>> Answering on behalf of Philippe as we had some discussion on this.
> >>>
> >>> What you can do is make the change and run the Ant task called "test".
> >>> properties used by test are located in
> >> bin/testfiles/jmetertest.properties.
> >>> You will get tests failures because all generated files will have an
> >>> additional field (threads) , as some test compare result files with
> >>> expected result files, they will logically fail.
> >>> So nothing complex in the change just some work to do to fix either the
> >>> test results or the properties used by test.
> >>> Maybe this can be discussed here with PMC.
> >>>
> >>> Regards
> >>>
> >>> On Fri, Sep 26, 2014 at 3:18 PM, Andrey Pokhilko <apc4@ya.ru> wrote:
> >>>
> >>>> Thanks for the link, Philippe.
> >>>>
> >>>> What prevents this change from being done? Is there really complex
> tests
> >>>> that break on this change? How can I help? (I'm not familiar with
> >>>> JMeter's source tests, unfortunately).
> >>>>
> >>>> Andrey Pokhilko
> >>>>
> >>>> On 09/26/2014 02:05 PM, Philippe Mouawad wrote:
> >>>>> Hi Andrey,
> >>>>> This has been discussed in a previous thread, see:
> >>>>>
> >>
> http://mail-archives.apache.org/mod_mbox/jmeter-dev/201404.mbox/%3CCAOGo0VaiM=TdW_Fj9fE1De4W8jao8ox5ELTAFVHTyN=5SY0d+Q@mail.gmail.com%3E
> >>>>> I think it is agreed upon by PMC members, changing this just breaks
> >> some
> >>>>> Tests that need to be fixed.
> >>>>>
> >>>>>
> >>>>>
> >>
> >
>
>


-- 
Cordialement.
Philippe Mouawad.

--20cf301afbbf6c469f05040a712a--