Return-Path: 
 <dev-return-3164-apmail-jmeter-dev-archive=jmeter.apache.org@jmeter.apache.org>
X-Original-To: apmail-jmeter-dev-archive@minotaur.apache.org
Delivered-To: apmail-jmeter-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 8304C11562
	for <apmail-jmeter-dev-archive@minotaur.apache.org>;
 Sun,  6 Apr 2014 21:26:52 +0000 (UTC)
Received: (qmail 79056 invoked by uid 500); 6 Apr 2014 21:26:52 -0000
Delivered-To: apmail-jmeter-dev-archive@jmeter.apache.org
Received: (qmail 78990 invoked by uid 500); 6 Apr 2014 21:26:51 -0000
Mailing-List: contact dev-help@jmeter.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@jmeter.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@jmeter.apache.org>
List-Post: <mailto:dev@jmeter.apache.org>
List-Id: <dev.jmeter.apache.org>
Reply-To: dev@jmeter.apache.org
Delivered-To: mailing list dev@jmeter.apache.org
Received: (qmail 78982 invoked by uid 99); 6 Apr 2014 21:26:51 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 06 Apr 2014 21:26:51 +0000
X-ASF-Spam-Status: No, hits=1.5 required=5.0
	tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: domain of philippe.mouawad@gmail.com
 designates 209.85.213.178 as permitted sender)
Received: from [209.85.213.178] (HELO mail-ig0-f178.google.com)
 (209.85.213.178)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 06 Apr 2014 21:26:47 +0000
Received: by mail-ig0-f178.google.com with SMTP id hn18so2904516igb.5
        for <dev@jmeter.apache.org>; Sun, 06 Apr 2014 14:26:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        bh=+geolNE9fcQGurruXcdB7UYNiek+4bHdzYarxYuFMDw=;
        b=iMAAhnnTvRe3tkqfjiy59AWqfFzvZuSQPzniTkahx8T90Gd77ikak787zVisaYm/g3
         PKaRzAgDIuN71AFL3Ml66rclsM5peAv91FKlz+iNaAs0Kw80Yj16IFnR5s9BdTC7fXus
         gWCBRtXEoOfD3mEO24lOszOzxUmg6rYeLcV4TEPBmscVg5A/T0kmld8nLp8fLchP1JAA
         l/t0c7gaVNy9oDHQl2T8awq28i0JERk9kyz2XzY5QaJfUXfM2VSjnTpeP5v6ByaBDBlG
         5YQEXpFA0JZIEEHNbS9Y+lpno9wV448uBlov+B1Vmt/tQ7DxZpau1z9DSi5nmFrVwtlF
         ngcg==
MIME-Version: 1.0
X-Received: by 10.50.56.51 with SMTP id x19mr2958469igp.5.1396819586666; Sun,
 06 Apr 2014 14:26:26 -0700 (PDT)
Received: by 10.42.200.7 with HTTP; Sun, 6 Apr 2014 14:26:26 -0700 (PDT)
In-Reply-To: 
 <CAOGo0Vavs+x7i-zy_jux5bmZdHhro62TVf2XLqcV5VE5DVNS4g@mail.gmail.com>
References: 
 <CAH9fUpYyJCizXPb1bRke0Gh=wjjCoFpoBcNNy7QLXB_TmubEAw@mail.gmail.com>
	<CAHnoMfqRanGVghAwJmSnVyeFtrmoFgUtc5Otw-eSUGGC7G54qQ@mail.gmail.com>
	<CAOGo0Vavs+x7i-zy_jux5bmZdHhro62TVf2XLqcV5VE5DVNS4g@mail.gmail.com>
Date: Sun, 6 Apr 2014 23:26:26 +0200
Message-ID: 
 <CAH9fUpZnQi0KteXnF90gDhxzBt=g3HMkYsSaGoa6rWJMRp=HJQ@mail.gmail.com>
Subject: Re: SaveService : Thread counts saving should be enabled by default
From: Philippe Mouawad <philippe.mouawad@gmail.com>
To: "dev@jmeter.apache.org" <dev@jmeter.apache.org>
Content-Type: multipart/alternative; boundary=089e0158b32847547a04f666677e
X-Virus-Checked: Checked by ClamAV on apache.org

--089e0158b32847547a04f666677e
Content-Type: text/plain; charset=ISO-8859-1

Hello sebb,
Changing this value breaks many test case due to the fact that newly saved
XML for jmx will contain:
<threadCounts>true</threadCounts>

Shall I change jmx test files or do you have an idea  ?
Thanks


On Tue, Feb 11, 2014 at 2:44 AM, sebb <sebbaz@gmail.com> wrote:

> I expect it was omitted by default as the field was not present originally.
>
> If the default is changed, it needs to be documented as a
> (potentially) breaking change, as it may affect existing tests.
>
> On 9 February 2014 15:37, Shmuel Krakower <shmulikk@gmail.com> wrote:
> > I also find it mandatory.
> > Up until now I override it with my user properties file and always copy
> > this file with every new release.
> >
> > www.beatsoo.org - free application performance monitoring from world
> wide
> > locations.
> > On Feb 9, 2014 5:24 PM, "Philippe Mouawad" <philippe.mouawad@gmail.com>
> > wrote:
> >
> >> Hello,
> >> It seems to me strange that in default config thread counts is not
> output
> >> in results:
> >> #jmeter.save.saveservice.thread_counts=false
> >>
> >> This value which usually represents the number of Virtual Users seems
> to me
> >> a mandatory value in every test. I don't remember not setting it to
> true in
> >> all tests I made.
> >>
> >> Would you be OK to change default value to true ?
> >>
> >>
> >> Regards
> >> Philippe
> >>
>



-- 
Cordialement.
Philippe Mouawad.

--089e0158b32847547a04f666677e--