Return-Path: X-Original-To: apmail-jmeter-dev-archive@minotaur.apache.org Delivered-To: apmail-jmeter-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6736610669 for ; Fri, 6 Sep 2013 14:34:39 +0000 (UTC) Received: (qmail 69261 invoked by uid 500); 6 Sep 2013 14:34:39 -0000 Delivered-To: apmail-jmeter-dev-archive@jmeter.apache.org Received: (qmail 69208 invoked by uid 500); 6 Sep 2013 14:34:30 -0000 Mailing-List: contact dev-help@jmeter.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jmeter.apache.org Delivered-To: mailing list dev@jmeter.apache.org Received: (qmail 69200 invoked by uid 99); 6 Sep 2013 14:34:28 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Sep 2013 14:34:28 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of sebbaz@gmail.com designates 74.125.82.171 as permitted sender) Received: from [74.125.82.171] (HELO mail-we0-f171.google.com) (74.125.82.171) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Sep 2013 14:34:23 +0000 Received: by mail-we0-f171.google.com with SMTP id t61so1937925wes.2 for ; Fri, 06 Sep 2013 07:34:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=OMBMtMTV95I396rKxE7SdY1rn7frnIZFHpYhd36JMQ0=; b=Xx6a+nVzUohmDfs7rMFozAvQ8wjA05HswnNgHmxBunDCrIqmW7e70NPtQLRJwOXzx6 f3X8F5PnfoAKSUzSzfaDe1uF7xy+bCG8FG89cLSQqW5+3gqSA5LAkNdkxTJYIyuaHB4D XrkHaKjceZiEEznE8EMqBWIz2//HxWypPahweZli6kNtFzfmIGKWxS+Bj/RcbvuIyAoq abFPRlpx1YFG2t39rF8Y9Pi421ycQNrE8FVkTmMatqJd7rmP+hn6pVJ4LNvvhn8tFfBZ z4eVeeYBYkkx1vW3uldoG8dnLZA5o63eZGSlsURzqCmxkFmcocB7bT/XZTfXGD5y+d0s YZxg== MIME-Version: 1.0 X-Received: by 10.195.13.45 with SMTP id ev13mr2369464wjd.20.1378478042165; Fri, 06 Sep 2013 07:34:02 -0700 (PDT) Received: by 10.194.16.167 with HTTP; Fri, 6 Sep 2013 07:34:02 -0700 (PDT) In-Reply-To: References: Date: Fri, 6 Sep 2013 15:34:02 +0100 Message-ID: Subject: Re: Suboptimal memory usage in ResponseAssertion From: sebb To: dev@jmeter.apache.org Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Checked: Checked by ClamAV on apache.org On 4 September 2013 23:42, Vladimir Sitnikov wrote: > Hi, > > I've noticed that ResponseAssertion does not cleanup regex matcher memory, > thus it keeps the whole web page in memory. > > RegexExtractor calls JMeterUtils.clearMatcherMemory(matcher, pattern); to > clean up the memory. > > Does is make sense to add the same cleanup to ResponseAssertion? > Same for HTTPSamplerBase -> downloadPageResources -> localMatcher Seems like it would be good to look at making such changes. Bugs and enhancement requests are normally done through Bugzilla, as it's much easier to track progress there. Would you be able to create Bugzilla requests for your suggested fixes? Patches welcome too, but not essential here as it should be obvious what to change. > -- > Regards, > Vladimir Sitnikov