jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1519088 - in /jmeter/trunk: bin/ src/core/org/apache/jmeter/ src/core/org/apache/jmeter/engine/ src/core/org/apache/jmeter/gui/action/ src/core/org/apache/jmeter/threads/ xdocs/
Date Fri, 30 Aug 2013 21:52:55 GMT
On 30 August 2013 22:24, Philippe Mouawad <philippe.mouawad@gmail.com> wrote:
> On Fri, Aug 30, 2013 at 11:19 PM, sebb <sebbaz@gmail.com> wrote:
>
>> On 30 August 2013 22:08,  <pmouawad@apache.org> wrote:
>> > Author: pmouawad
>> > Date: Fri Aug 30 21:08:16 2013
>> > New Revision: 1519088
>> >
>> > URL: http://svn.apache.org/r1519088
>> > Log:
>> > Bug 54152 - In distributed testing : activeThreads and totalThreads
>> always show 0
>> > Bugzilla Id: 54152
>>
>> Good to have that fixed at last.
>>
>> > Added:
>> >
>> jmeter/trunk/src/core/org/apache/jmeter/threads/RemoteThreadsListener.java
>>   (with props)
>> >
>> jmeter/trunk/src/core/org/apache/jmeter/threads/RemoteThreadsListenerImpl.java
>>   (with props)
>> >
>> jmeter/trunk/src/core/org/apache/jmeter/threads/RemoteThreadsListenerTestElement.java
>>   (with props)
>> >
>> jmeter/trunk/src/core/org/apache/jmeter/threads/RemoteThreadsListenerWrapper.java
>>   (with props)
>> > Modified:
>> >     jmeter/trunk/bin/saveservice.properties
>> >     jmeter/trunk/src/core/org/apache/jmeter/JMeter.java
>> >     jmeter/trunk/src/core/org/apache/jmeter/engine/ConvertListeners.java
>> >     jmeter/trunk/src/core/org/apache/jmeter/gui/action/RemoteStart.java
>> >     jmeter/trunk/xdocs/changes.xml
>> >
>> > Modified: jmeter/trunk/src/core/org/apache/jmeter/JMeter.java
>> > URL:
>> http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/JMeter.java?rev=1519088&r1=1519087&r2=1519088&view=diff
>> >
>> ==============================================================================
>> > --- jmeter/trunk/src/core/org/apache/jmeter/JMeter.java (original)
>> > +++ jmeter/trunk/src/core/org/apache/jmeter/JMeter.java Fri Aug 30
>> 21:08:16 2013
>> > @@ -77,6 +77,7 @@ import org.apache.jmeter.save.SaveServic
>> >  import org.apache.jmeter.services.FileServer;
>> >  import org.apache.jmeter.testelement.TestElement;
>> >  import org.apache.jmeter.testelement.TestStateListener;
>> > +import org.apache.jmeter.threads.RemoteThreadsListenerTestElement;
>> >  import org.apache.jmeter.util.BeanShellInterpreter;
>> >  import org.apache.jmeter.util.BeanShellServer;
>> >  import org.apache.jmeter.util.JMeterUtils;
>> > @@ -784,6 +785,8 @@ public class JMeter implements JMeterPlu
>> >                      tree.add(tree.getArray()[0], summer);
>> >                  }
>> >              }
>> > +            // Used for remote notification of threads start/stop,see
>> BUG 54152
>> > +            tree.add(tree.getArray()[0], new
>> RemoteThreadsListenerTestElement());
>>
>> But why add the listener here - surely this is only used in non-GUI
>> mode which does not have a display to update?
>>
> It is also usable in GUI mode, it will show active threads. For now as I
> commented, totalNumber of threads in all Thread groups will still show 0 in
> Remote Test

The above code is part of the method

    org.apache.jmeter.JMeter.runNonGui()

which is only used to run non-GUI client tests - is it *really* needed?

>
> --
> Cordialement.
> Philippe Mouawad.

Mime
View raw message