Mailing-List: contact dev-help@jmeter.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jmeter.apache.org
Received-SPF: pass (nike.apache.org: domain of philippe.mouawad@gmail.com
 designates 209.85.223.175 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAOGo0VYRX400t=OC4i881oMyofkgdwg0B4=Hdv8JsYmJxBdKWg@mail.gmail.com>
References: 
 <CAH9fUpZEYCOdJ=z7THt6+LQ-cBTrvQfTKB=vtBrQaqMHTWe1bw@mail.gmail.com>
	<CAH9fUpZqeHf4djcSb+Rrbx6XJr4hP7pXKfw-z4HSvFaXYVadPQ@mail.gmail.com>
	<CAOGo0VYRX400t=OC4i881oMyofkgdwg0B4=Hdv8JsYmJxBdKWg@mail.gmail.com>
Date: Tue, 2 Jul 2013 12:36:26 +0200
Message-ID: 
 <CAH9fUpbigh1YsCmBpo6QMVsWRn+VP2TFBrvLAtu9CYroZ3pzCA@mail.gmail.com>
Subject: Re: Refactoring in HTTPHC4Impl
From: Philippe Mouawad <philippe.mouawad@gmail.com>
To: dev@jmeter.apache.org
Content-Type: multipart/alternative; boundary=089e01494eeec7e69a04e084ea11

--089e01494eeec7e69a04e084ea11
Content-Type: text/plain; charset=ISO-8859-1

Hello sebb,
I attached patch.

Regards
Philippe

On Tue, Jul 2, 2013 at 1:21 AM, sebb <sebbaz@gmail.com> wrote:

> On 1 July 2013 16:18, Philippe Mouawad <philippe.mouawad@gmail.com> wrote:
> > Created bug:
> > https://issues.apache.org/bugzilla/show_bug.cgi?id=55175
> >
> > Waiting for your feedback before commit.
>
> We'll need a bit more detail.
> What exactly are you proposing?
>
> Note that making a method protected usually means freezing its API, so
> the API had better be correct before doing so.
>
> However, if the inheritance is intended only for use by JMeter code -
> and is clear;y documented as such - then the API could be changed if
> necessary.
>
> If it is for use by 3rd party plugins, then the API design needs a lot
> of care to ensure it does not restrict future development.
>
> > On Mon, Jul 1, 2013 at 5:06 PM, Philippe Mouawad <
> philippe.mouawad@gmail.com
> >> wrote:
> >
> >> Hello,
> >> As per sebb request, I ask before implementing :-)
> >>
> >> I would like to refactor slightly HTTPHC4Impl to allow inheritance from
> it
> >> to reuse many of already implemented and useful internals.
> >> This would be useful to classes that which for example to post binary
> >> content and similar stuff.
> >>
> >> Are you ok with it ? Can I open a bugzilla and do it ?
> >>
> >> Thanks
> >> --
> >> Regards.
> >> Philippe.
> >>
> >>
> >>
> >
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
>


-- 
Cordialement.
Philippe Mouawad.

--089e01494eeec7e69a04e084ea11--