jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: Drag & Drop incompatible behaviour change
Date Fri, 12 Jul 2013 21:13:18 GMT
On 12 July 2013 19:49, Philippe Mouawad <philippe.mouawad@gmail.com> wrote:
> On Fri, Jul 12, 2013 at 8:03 PM, sebb <sebbaz@gmail.com> wrote:
>
>> On 12 July 2013 18:37, Philippe Mouawad <philippe.mouawad@gmail.com>
>> wrote:
>> > On Fri, Jul 12, 2013 at 7:24 PM, sebb <sebbaz@gmail.com> wrote:
>> >
>> >> In 2.9 and earlier, it used to be possible to move an element and drop
>> >> it before, after, or as a child of the drop target.
>> >>
>> >> The drop destination option box no longer appears, and it seems to be
>> >> impossible to move an element after last element at that level.
>> >>
>> >> The drop destination is no longer needed as there is a visual clue of
>> > where you are.
>> >
>> >
>> >> For example, create:
>> >>
>> >> TestPlan
>> >> + ThreadGroup
>> >> + + Sampler 1
>> >> + + Sampler 2
>> >> + + Sampler 3
>> >> Workbench
>> >>
>> >> Now try to drag Sampler 2 to appear after Sampler 3 - it's not possible.
>> >> [Note - Alt+Down does work OK]
>> >>
>> >> Is this intended?
>> >>
>> >
>> > Regarding last element, see comment in
>> > https://issues.apache.org/bugzilla/show_bug.cgi?id=54834:
>> > - http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6560955
>> >
>> > The workaround is to drop it before and DnD the last to before the one
>> just
>> > dropped.
>> >
>>
>> Then this needs to be documented in the changes.
>>
>> Done

Thanks.

>> I don't suppose it's possible to detect the problem and warn the user
>> if they try to select that location?
>>
>> It would be possible but if you popup a warning couldn't it be a bit
> annoying ?

Depends whether the warning had to be cancelled or just appeared and
disappeared.

>> >
>> >>
>> >> Also, the displayed test element always changes to the WorkBench, but
>> >> no element is shown as selected.
>> >> Previously it used to change to the drop target.
>> >>
>> > Can you clarify ?
>>
>> Select an element; it is marked as selected and appears on the RHS
>> Move it anywhere.
>> There is no element marked as selected, and the RHS shows the WorkBench
>>
>> Fixed now as you noted
>
>> > Thanks
>> >
>>
>> There's some other odd behaviour:
>>
>> Alt+Left always moves up a level and adds the element just before its
>> previous parent.
>> That's fine.
>>
>> Alt+Right moves e.g. a Listener to be a child of the following
>> sampler. It refuses to move a sampler under a sampler (which is fine).
>>
>> However use Alt+Right on a Listener child of a sampler, and instead of
>> ignoring the request (there's no lower level), the Listener is brought
>> back up to the same level as the sampler but immediately after it -
>> provided that the sampler was not the last element at that level.
>>
>> Start:
>>
>> Listener
>> Sampler 1
>> Sampler 2
>>
>> After Alt+Right on Listener
>>
>> Sampler 1
>> + Listener
>> Sampler 2
>>
>> That's OK
>>
>> After Alt+Right on Listener
>>
>> Sampler 1
>> Listener
>> Sampler 2
>>
>> Huh?
>>
>>
> Well in fact it does not disturb me that much as it allows you to navigate
> to next node, what would you like it to do ?

I think it should just refuse to move the element; it's inconsistent otherwise.

>
>> After Alt+Right on Listener
>>
>> Sampler 1
>> Sampler 2
>> + Listener
>>
>> OK
>>
>
>
>> >
>> >
>> > --
>> > Cordialement.
>> > Philippe Mouawad.
>>
>
>
>
> --
> Cordialement.
> Philippe Mouawad.

Mime
View raw message