jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philippe Mouawad <philippe.moua...@gmail.com>
Subject Re: svn commit: r1500124 - in /jmeter/trunk: ./ res/maven/ src/components/org/apache/jmeter/assertions/gui/ src/core/org/apache/jmeter/testbeans/gui/ src/protocol/java/org/apache/jmeter/protocol/java/control/gui/ xdocs/
Date Sat, 06 Jul 2013 08:38:27 GMT
you need to add a throws in one method, it is in the build output

On Saturday, July 6, 2013, Milamber wrote:

>
> Le 06/07/2013 00:08, sebb a ecrit :
>
>> On 5 July 2013 23:17, sebb <sebbaz@gmail.com> wrote:
>>
>>> On 5 July 2013 23:10, sebb <sebbaz@gmail.com> wrote:
>>>
>>>> On 5 July 2013 22:53, Milamber <milamberspace@gmail.com> wrote:
>>>>
>>>>> Le 05/07/2013 22:40, sebb a ecrit :
>>>>>
>>>>>  On 5 July 2013 22:36, Milamber <milamber@apache.org> wrote:
>>>>>>
>>>>>>> Le 05/07/2013 21:55, sebb a ecrit :
>>>>>>>
>>>>>>>> On 5 July 2013 21:39,  <milamber@apache.org> wrote:
>>>>>>>>
>>>>>>>>  Author: milamber
>>>>>>>>> Date: Fri Jul  5 20:39:54 2013
>>>>>>>>> New Revision: 1500124
>>>>>>>>>
>>>>>>>>> URL: http://svn.apache.org/r1500124
>>>>>>>>> Log:
>>>>>>>>> Bug 55202 - Proposal to add RSyntaxTextArea for BeanShell,
BSF, and
>>>>>>>>> JSR223 elements
>>>>>>>>> Bugzilla Id: 55202
>>>>>>>>>
>>>>>>>> -1
>>>>>>>>
>>>>>>>> I think the jar needs to be obtained somewhere other than
Maven
>>>>>>>> Central, as the pom license there says LGPL.
>>>>>>>>
>>>>>>>
>>>>>>> Not good...
>>>>>>>
>>>>>>> I have sent an email to Filesolft (author of rsyntaxtextarea)
to
>>>>>>> point
>>>>>>> the
>>>>>>> difference between their website and the pom file on Maven website,
>>>>>>> and
>>>>>>> ask
>>>>>>> the good license.
>>>>>>>
>>>>>> That would be the best solution - having an incorrect license on
Maven
>>>>>> is not good.
>>>>>>
>>>>>> However we do have other options:
>>>>>> - download the example archive and extract the jar:
>>>>>>
>>>>>> http://sourceforge.net/**projects/rsyntaxtextarea/**
>>>>>> files/rsyntaxtextarea-demo/2.**0.7/rsyntaxtextarea_demo_2.0.**
>>>>>> 7.zip/download<http://sourceforge.net/projects/rsyntaxtextarea/files/rsyntaxtextarea-demo/2.0.7/rsyntaxtextarea_demo_2.0.7.zip/download>
>>>>>> - download the source to a temporary folder and compile it
>>>>>>
>>>>>
>>>>> You're right, another option is:
>>>>> (on download_jars task)
>>>>> Download form the binary release (not -demo)
>>>>> http://sourceforge.net/**projects/rsyntaxtextarea/**
>>>>> files/rsyntaxtextarea/2.0.7/**rsyntaxtextarea_2.0.7.zip/**download<http://sourceforge.net/projects/rsyntaxtextarea/files/rsyntaxtextarea/2.0.7/rsyntaxtextarea_2.0.7.zip/download>
>>>>> The zip file include the modified BSD license.
>>>>>
>>>>> Get the jar file and put on good directory.
>>>>>
>>>>> It is a good way ? or we must compile from source?
>>>>>
>>>> I think that's OK, the license in the zip looks to be the same (best
>>>> to check though).
>>>>
>>>> Not sure if build.xml still has the code to do zip extraction, if not
>>>> it can be recovered from SVN history.
>>>>
>>>> The extracted jar will still contain the example code.
>>>> If that turns out to be a problem, then using the source should not be
>>>> too hard to do.
>>>>
>>> Looks like the jar in the example zip is incomplete; it does not have
>> the class:
>>
>> org.fife.ui.rsyntaxtextarea.**modes.ActionScriptTokenMaker
>>
>> The JMeter test generates lots of stack trace output. presumably from
>> somewhere in the RSyntaxTextArea code.
>> I think that's a bug - either the exception should be propagated back
>> to the caller, or the exception should be handled silently.
>>
>> Anyway, I think we'll probably need to download the source and compile it.
>>
>
> When I try tom compile from source zip with JDK 1.6, I have this warning
> and errors:
>
>      [echo] NOTE: *** RSyntaxTextArea is built with a 1.4.2 JDK!
>      [echo] NOTE: *** If you build with Java 5 or newer, you will receive
> a compile error
>      [echo] NOTE: *** about an XmlParser.java method missing IOException
> in its throws
>      [echo] NOTE: *** clause.  This is caused by a binary incompatibility
> between Java
>      [echo] NOTE: *** 1.4 and Java 5.  To remedy this, either build with
> 1.4.2, or add
>      [echo] NOTE: *** IOException to the throws clause.
>     [javac] Compiling 161 source files to /root/Rsyntax/ant-classes
>     [javac] /root/Rsyntax/src/org/fife/ui/**rtextarea/**
> RTATextTransferHandler.java:**17: warning: [deprecation] java.io.**StringBufferInputStream
> in java.io has been deprecated
>     [javac] import java.io.**StringBufferInputStream;
>     [javac]               ^
>     [javac] /root/Rsyntax/src/org/fife/ui/**rsyntaxtextarea/**RtfTransferable.java:41:
> warning: [deprecation] plainTextFlavor in java.awt.datatransfer.**DataFlavor
> has been deprecated
>     [javac]         DataFlavor.plainTextFlavor // deprecated
>     [javac]                   ^
>     [javac] /root/Rsyntax/src/org/fife/ui/**rsyntaxtextarea/parser/**XmlParser.java:219:
> unreported exception java.io.IOException; must be caught or declared to be
> thrown
>     [javac]             return super.resolveEntity(publicId, systemId);
>     [javac]                                       ^
>     [javac] /root/Rsyntax/src/org/fife/ui/**rtextarea/**
> RTATextTransferHandler.java:**356: warning: [deprecation] java.io.**StringBufferInputStream
> in java.io has been deprecated
>     [javac]                     return new StringBufferInputStream(data);
>     [javac]                                ^
>     [javac] 1 error
>     [javac] 3 warnings
>
>
> Not very great... I will try from binary zip file to get directly the jar.
>
>
>  The code could check if the jar is present, and if not, download and
> build.
>
> It's just occured to me - the Maven jar was not created by the
> project, so may not be trustworthy.
>
>  - ask on legal discuss if this really is a problem or not
>
>
>  Please remove the download part for now.
>
>  Added:
>
>
> jmeter/trunk/src/core/org/**apache/jmeter/testbeans/gui/**
> textarea.properties
> (with props)
> Modified:
>        jmeter/trunk/LICENSE
>        jmeter/trunk/build.properties
>        jmeter/trunk/build.xml
>        jmeter/trunk/eclipse.classpath
>        jmeter/trunk/res/maven/**ApacheJMeter_parent.pom
>
>
> jmeter/trunk/src/components/**org/apache/jmeter/assertions/**
> gui/BeanShellAssertionGui.java
>
>
> jmeter/trunk/src/core/org/**apache/jmeter/testbeans/gui/**
> GenericTestBeanCustomizer.java
>
>
> jmeter/trunk/src/core/org/**apache/jmeter/testbeans/gui/**
> TextAreaEditor.java
>
>
> jmeter/trunk/src/core/org/**apache/jmeter/testbeans/gui/**
> WrapperEditor.java
>
>
> jmeter/trunk/src/protocol/**java/org/apache/jmeter/**
> protocol/java/control/gui/**BeanShellSamplerGui.java
>        jmeter/trunk/xdocs/changes.xml
>
> Modified: jmeter/trunk/LICENSE
> URL:
>
> http://svn.apache.org/viewvc/**jmeter/trunk/LICENSE?rev=**
> 1500124&r1=1500123&r2=1500124&**view=diff<http://svn.apache.org/viewvc/jmeter/trunk/LICENSE?rev=1500124&r1=1500123&r2=1500124&view=diff>
>
>
> ==============================**==============================**
> ==================
> --- jmeter/trunk/LICENSE [utf-8] (original)
> +++ jmeter/trunk/LICENSE [utf-8] Fri Jul  5 20:39:54 2013
> @@ -1565,7 +1565,7 @@ The jsoup code-base (include source and
>     distributed under the open source MIT license as described below.
>     The MIT License
>
> -Copyright � 2009 - 2012 Jonathan Hedley (jonathan@hedley.net)
> +Copyright � 2009 - 2012 Jonathan Hedley (jonathan@hedley.net)
>
>     Permission is hereby granted, free of charge, to any person
> obtaining a
>     copy of this software and associated documentation files (the
> "Software"),
> @@ -1926,7 +1926,7 @@ As a special exception, the copyright ho
>     Open Icon Library from
>     http://openiconlibrary.**sourceforge.net/<http://openiconlibrary.sourceforge.net/>
>
> -Detailled Licenses information:
> +Detailed Licenses information:
>     http://openiconlibrary.**sourceforge.net/LICENSES.html<http://openiconlibrary.sourceforge.net/LICENSES.html>
>
>     ============ Packages used by Apache JMeter =========
> @@ -2029,3 +2029,39 @@ UNLESS OTHERWISE MUTUALLY AGREED TO BY T
>
>
>
> ##############################**##############################**
> ####################
>
> +RSyntaxTextArea License
> +=============================**============
> +
> +RSyntaxTextArea  from
> +http://fifesoft.com/**rsyntaxtextarea/<http://fifesoft.com/rsyntaxtextarea/>
> +
> +Detailed License information:
> +http://fifesoft.com/**rsyntaxtextarea/**RSyntaxTextArea.License.txt<http://fifesoft.com/rsyntaxtextarea/RSyntaxTextArea.License.txt>
> +
> +============== RSyntaxTextArea  License =============
> +Copyright (c) 2012, Robert Futrell
> +All rights reserved.
> +
> +Redistribution and use in source and binary forms, with or without
> +modification, are permitted provided that the following conditions are
> met:
> +    * Redistributions of source code must retain the above copyright
> +      notice, this list of conditions and the following disclaimer.
> +    * Redistributions in binary form must reproduce the above
> copyright
> +      notice, thi
>
>

-- 
Cordialement.
Philippe Mouawad.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message