Mailing-List: contact dev-help@jmeter.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jmeter.apache.org
Received-SPF: pass (nike.apache.org: domain of philippe.mouawad@gmail.com
 designates 209.85.223.182 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAH9fUpZgPK7s_ps-+LatTHRg66pu5Ppp5skzTUhNemrcTAokPg@mail.gmail.com>
References: <20130401200534.47B0023888CD@eris.apache.org>
	<CAOGo0VYJC_5bxXjxp75sE2+i1mPKq7KsqdH5o3PF5eBXhQbZ_A@mail.gmail.com>
	<CAH9fUpavD3e8T3z5Z2EuA2=yhgDWwjkuTHHFmeQ+pApS2K=uxQ@mail.gmail.com>
	<CAOGo0Va3vzQHshaXWM-nrz5r9EvO7N27uLF5gDF-_s_Y+2M4eQ@mail.gmail.com>
	<CAH9fUpZgPK7s_ps-+LatTHRg66pu5Ppp5skzTUhNemrcTAokPg@mail.gmail.com>
Date: Thu, 4 Apr 2013 16:52:44 +0200
Message-ID: 
 <CAH9fUpY23xCwXg9z25nu=YUtcANKKC=WFs3-LF5TgUfS7kftuQ@mail.gmail.com>
Subject: Re: svn commit: r1463274 - in /jmeter/trunk:
 src/core/org/apache/jmeter/reporters/ResultCollector.java
 xdocs/changes.xml
From: Philippe Mouawad <philippe.mouawad@gmail.com>
To: dev@jmeter.apache.org
Content-Type: multipart/alternative; boundary=14dae9340c8386837404d98a1f37

--14dae9340c8386837404d98a1f37
Content-Type: text/plain; charset=ISO-8859-1

Done

On Wed, Apr 3, 2013 at 12:48 PM, Philippe Mouawad <
philippe.mouawad@gmail.com> wrote:

> I agree with you so:
>
>    - Document change
>    - Add a property which by default is new value (autoflush = false) and
>    document it
>
> Regards
>
> Philippe
>
> On Wed, Apr 3, 2013 at 12:22 PM, sebb <sebbaz@gmail.com> wrote:
>
>> On 3 April 2013 07:00, Philippe Mouawad <philippe.mouawad@gmail.com>
>> wrote:
>>
>> > Hello Sebb,
>> > I think today if jmeter crashes before the flusj we will have an
>> incomplete
>> > file, the difference is that now it can loose up to 8kb.
>> >
>> > I don't remember  seing jmeter crash in my testing experiences and if it
>> > does it would mean:
>> > - it was overloaded so test has big chances to be invalid
>> > - or we met a java bug , rather very rare.
>> >
>> > I can add a config parameter but don't we have a lot ?
>> >
>>
>> A property would be sufficient.
>>
>> In any case, the change needs to be properly documented, especially if the
>> default is changed (that needs to be identified as an Incompatible
>> Change).
>>
>>
>> > Regards
>> > Philippe
>> >
>> > On Wednesday, April 3, 2013, sebb wrote:
>> >
>> > > On 1 April 2013 21:05, <pmouawad@apache.org <javascript:;>> wrote:
>> > >
>> > > > Author: pmouawad
>> > > > Date: Mon Apr  1 20:05:33 2013
>> > > > New Revision: 1463274
>> > > >
>> > > > URL: http://svn.apache.org/r1463274
>> > > > Log:
>> > > > Bug 54777 - Improve Performance of default ResultCollector
>> > > > Bugzilla Id: 54777
>> > > >
>> > > >
>> > > -1
>> > >
>> > > I think the change is wrong as it stands.
>> > >
>> > > Dropping autoflush means that some files might be incomplete if JMeter
>> > > crashes.
>> > > And the change is not even identified as a behaviour change.
>> > >
>> > > I think the change needs to be optional.
>> > > I'm not convinced that the default needs to be changed.
>> > > And the change needs to be better documented.
>> > >
>> > > Modified:
>> > > >
>> > > jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java
>> > > >     jmeter/trunk/xdocs/changes.xml
>> > > >
>> > > > Modified:
>> > > >
>> jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java
>> > > > URL:
>> > > >
>> > >
>> >
>> http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java?rev=1463274&r1=1463273&r2=1463274&view=diff
>> > > >
>> > > >
>> > >
>> >
>> ==============================================================================
>> > > > ---
>> > > jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java
>> > > > (original)
>> > > > +++
>> > > jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java
>> > > > Mon Apr  1 20:05:33 2013
>> > > > @@ -420,7 +420,7 @@ public class ResultCollector extends Abs
>> > > >                  }
>> > > >              }
>> > > >              writer = new PrintWriter(new OutputStreamWriter(new
>> > > > BufferedOutputStream(new FileOutputStream(filename,
>> > > > -                    trimmed)),
>> SaveService.getFileEncoding("UTF-8")),
>> > > > true); // $NON-NLS-1$
>> > > > +                    trimmed)),
>> SaveService.getFileEncoding("UTF-8")),
>> > > > false); // $NON-NLS-1$
>> > > >              log.debug("Opened file: "+filename);
>> > > >              files.put(filename, new FileEntry(writer, saveConfig));
>> > > >          } else {
>> > > >
>> > > > Modified: jmeter/trunk/xdocs/changes.xml
>> > > > URL:
>> > > >
>> > >
>> >
>> http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1463274&r1=1463273&r2=1463274&view=diff
>> > > >
>> > > >
>> > >
>> >
>> ==============================================================================
>> > > > --- jmeter/trunk/xdocs/changes.xml (original)
>> > > > +++ jmeter/trunk/xdocs/changes.xml Mon Apr  1 20:05:33 2013
>> > > > @@ -153,6 +153,7 @@ This does not affect JMeter operation.
>> > > >  <ul>
>> > > >  <li><bugzilla>54532</bugzilla> - Improve Response Time Graph Y axis
>> > > scale
>> > > > with huge values or small values (&lt; 1000ms). Add a new field to
>> > define
>> > > > increment scale</li>
>> > > >  <li><bugzilla>54576</bugzilla> - View Results Tree : Add a
>> CSS/JQuery
>> > > > Tester</li>
>> > > > +<li><bugzilla>54777</bugzilla> - Improve Performance of default
>> > > > ResultCollector</li>
>> > > >  </ul>
>> > > >
>> > > >  <h3>Timers, Assertions, Config, Pre- &amp; Post-Processors</h3>
>> > > >
>> > > >
>> > > >
>> > >
>> >
>> >
>> > --
>> > Cordialement.
>> > Philippe Mouawad.
>> >
>>
>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>
>
>


-- 
Cordialement.
Philippe Mouawad.

--14dae9340c8386837404d98a1f37--