On 1 April 2013 21:05, <pmouawad@apache.org> wrote:
> Author: pmouawad
> Date: Mon Apr 1 20:05:33 2013
> New Revision: 1463274
>
> URL: http://svn.apache.org/r1463274
> Log:
> Bug 54777 - Improve Performance of default ResultCollector
> Bugzilla Id: 54777
>
>
-1
I think the change is wrong as it stands.
Dropping autoflush means that some files might be incomplete if JMeter
crashes.
And the change is not even identified as a behaviour change.
I think the change needs to be optional.
I'm not convinced that the default needs to be changed.
And the change needs to be better documented.
Modified:
> jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java
> jmeter/trunk/xdocs/changes.xml
>
> Modified:
> jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java
> URL:
> http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java?rev=1463274&r1=1463273&r2=1463274&view=diff
>
> ==============================================================================
> --- jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java
> (original)
> +++ jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java
> Mon Apr 1 20:05:33 2013
> @@ -420,7 +420,7 @@ public class ResultCollector extends Abs
> }
> }
> writer = new PrintWriter(new OutputStreamWriter(new
> BufferedOutputStream(new FileOutputStream(filename,
> - trimmed)), SaveService.getFileEncoding("UTF-8")),
> true); // $NON-NLS-1$
> + trimmed)), SaveService.getFileEncoding("UTF-8")),
> false); // $NON-NLS-1$
> log.debug("Opened file: "+filename);
> files.put(filename, new FileEntry(writer, saveConfig));
> } else {
>
> Modified: jmeter/trunk/xdocs/changes.xml
> URL:
> http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1463274&r1=1463273&r2=1463274&view=diff
>
> ==============================================================================
> --- jmeter/trunk/xdocs/changes.xml (original)
> +++ jmeter/trunk/xdocs/changes.xml Mon Apr 1 20:05:33 2013
> @@ -153,6 +153,7 @@ This does not affect JMeter operation.
> <ul>
> <li><bugzilla>54532</bugzilla> - Improve Response Time Graph Y axis
scale
> with huge values or small values (< 1000ms). Add a new field to define
> increment scale</li>
> <li><bugzilla>54576</bugzilla> - View Results Tree : Add a CSS/JQuery
> Tester</li>
> +<li><bugzilla>54777</bugzilla> - Improve Performance of default
> ResultCollector</li>
> </ul>
>
> <h3>Timers, Assertions, Config, Pre- & Post-Processors</h3>
>
>
>
|