jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philippe Mouawad <philippe.moua...@gmail.com>
Subject Re: svn commit: r1463274 - in /jmeter/trunk: src/core/org/apache/jmeter/reporters/ResultCollector.java xdocs/changes.xml
Date Wed, 03 Apr 2013 06:00:51 GMT
Hello Sebb,
I think today if jmeter crashes before the flusj we will have an incomplete
file, the difference is that now it can loose up to 8kb.

I don't remember  seing jmeter crash in my testing experiences and if it
does it would mean:
- it was overloaded so test has big chances to be invalid
- or we met a java bug , rather very rare.

I can add a config parameter but don't we have a lot ?

Regards
Philippe

On Wednesday, April 3, 2013, sebb wrote:

> On 1 April 2013 21:05, <pmouawad@apache.org <javascript:;>> wrote:
>
> > Author: pmouawad
> > Date: Mon Apr  1 20:05:33 2013
> > New Revision: 1463274
> >
> > URL: http://svn.apache.org/r1463274
> > Log:
> > Bug 54777 - Improve Performance of default ResultCollector
> > Bugzilla Id: 54777
> >
> >
> -1
>
> I think the change is wrong as it stands.
>
> Dropping autoflush means that some files might be incomplete if JMeter
> crashes.
> And the change is not even identified as a behaviour change.
>
> I think the change needs to be optional.
> I'm not convinced that the default needs to be changed.
> And the change needs to be better documented.
>
> Modified:
> >
> jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java
> >     jmeter/trunk/xdocs/changes.xml
> >
> > Modified:
> > jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java
> > URL:
> >
> http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java?rev=1463274&r1=1463273&r2=1463274&view=diff
> >
> >
> ==============================================================================
> > ---
> jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java
> > (original)
> > +++
> jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java
> > Mon Apr  1 20:05:33 2013
> > @@ -420,7 +420,7 @@ public class ResultCollector extends Abs
> >                  }
> >              }
> >              writer = new PrintWriter(new OutputStreamWriter(new
> > BufferedOutputStream(new FileOutputStream(filename,
> > -                    trimmed)), SaveService.getFileEncoding("UTF-8")),
> > true); // $NON-NLS-1$
> > +                    trimmed)), SaveService.getFileEncoding("UTF-8")),
> > false); // $NON-NLS-1$
> >              log.debug("Opened file: "+filename);
> >              files.put(filename, new FileEntry(writer, saveConfig));
> >          } else {
> >
> > Modified: jmeter/trunk/xdocs/changes.xml
> > URL:
> >
> http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1463274&r1=1463273&r2=1463274&view=diff
> >
> >
> ==============================================================================
> > --- jmeter/trunk/xdocs/changes.xml (original)
> > +++ jmeter/trunk/xdocs/changes.xml Mon Apr  1 20:05:33 2013
> > @@ -153,6 +153,7 @@ This does not affect JMeter operation.
> >  <ul>
> >  <li><bugzilla>54532</bugzilla> - Improve Response Time Graph
Y axis
> scale
> > with huge values or small values (&lt; 1000ms). Add a new field to define
> > increment scale</li>
> >  <li><bugzilla>54576</bugzilla> - View Results Tree : Add a CSS/JQuery
> > Tester</li>
> > +<li><bugzilla>54777</bugzilla> - Improve Performance of default
> > ResultCollector</li>
> >  </ul>
> >
> >  <h3>Timers, Assertions, Config, Pre- &amp; Post-Processors</h3>
> >
> >
> >
>


-- 
Cordialement.
Philippe Mouawad.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message