jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kurt Hong <k...@uangel.com>
Subject A patch for TCP Sampler
Date Sat, 01 Dec 2012 13:12:39 GMT
Hello,

Please find the attached diff file for source code and screen capture images for xdoc.
I made a patch for TCP Sampler and TCP Sampler Config. This patch was originally made for
our companyí»s testing.

Things changed

-    On TCP Sampler Config

Add í░SO_LINGERí▒ checkbox and í░LINGER Timeoutí▒ text input box to prevent large numbers
of sockets sitting around with a TIME_WAIT status. Ití»s related to https://issues.apache.org/bugzilla/show_bug.cgi?id=40499

Add í░End of line(EOL) byte valueí▒ text input box to set eolByte value on GUI. Setting on
GUI will overwrite the setting in properties file. If user doesní»t set the value on GUI,
It will use the setting on properties file.

Remove í░Re-Use Connectioní▒ checkbox, and it will be shown only on TCP Sampler as in case
of checkbox, if user utilizes TCP Sampler and TCP Sampler Config together, the settings on
the TCP Sampler Config are meaningless.

Remove í░TCP Nodelayí▒ checkbox, and it will be shown only on TCP Sampler.

-    On TCP Sampler

Add í░Close Connectioní▒ checkbox to be able to close connection even if user checks í░Re-Use
Connectioní▒ option. In our companyí»s test, we needed to close the connection at the end
of each thread.



Also the diff contains a little GUI adjustment for TCP Sampler and Config.



Attached two imagesí» location is /jmeter/xdocs/images/screenshots.



The issue - https://issues.apache.org/bugzilla/show_bug.cgi?id=40499 - is related to this
patch but, he said too generally, not particularly about TCP Sampler. So I will not change
the status of the issue.



TODO(Next time)

-    Change check boxes to select boxes for those options.



Thank you!


-------------------------------
╚ź▒┘Ż─
ă├ĚžĂű░│╣▀║╬/ă├ĚžĂű░│╣▀3Ă└/░˙└ň
└╠ŞŮ└¤: kurt@uangel.com
Ş­╣┘└¤: 010-7289-7255
└»┐ú┴ę(┴Í)
-------------------------------

Mime
  • Unnamed multipart/mixed (inline, None, 0 bytes)
View raw message