Mailing-List: contact dev-help@jmeter.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jmeter.apache.org
Received-SPF: pass (nike.apache.org: domain of sebbaz@gmail.com designates
 209.85.214.171 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <20120623220622.A8892238899C@eris.apache.org>
References: <20120623220622.A8892238899C@eris.apache.org>
Date: Sun, 24 Jun 2012 01:38:22 +0100
Message-ID: 
 <CAOGo0VbDcSf0Nep80va942gKLMW5PMJ8oAr4tf2qZBUXGYHJyw@mail.gmail.com>
Subject: Re: svn commit: r1353205 - in /jmeter/trunk:
 src/core/org/apache/jmeter/util/JsseSSLManager.java
 xdocs/changes.xml
From: sebb <sebbaz@gmail.com>
To: dev@jmeter.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On 23 June 2012 23:06,  <pmouawad@apache.org> wrote:
> Author: pmouawad
> Date: Sat Jun 23 22:06:21 2012
> New Revision: 1353205
>
> URL: http://svn.apache.org/viewvc?rev=3D1353205&view=3Drev
> Log:
> Bug 53440 - SSL connection leads to ArrayStoreException on JDK 6 with som=
e KeyManagerFactory SPI
> Bugzilla Id: 53440

Very good catch.

> Modified:
> =A0 =A0jmeter/trunk/src/core/org/apache/jmeter/util/JsseSSLManager.java
> =A0 =A0jmeter/trunk/xdocs/changes.xml
>
> Modified: jmeter/trunk/src/core/org/apache/jmeter/util/JsseSSLManager.jav=
a
> URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter=
/util/JsseSSLManager.java?rev=3D1353205&r1=3D1353204&r2=3D1353205&view=3Ddi=
ff
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- jmeter/trunk/src/core/org/apache/jmeter/util/JsseSSLManager.java (ori=
ginal)
> +++ jmeter/trunk/src/core/org/apache/jmeter/util/JsseSSLManager.java Sat =
Jun 23 22:06:21 2012
> @@ -232,13 +232,17 @@ public class JsseSSLManager extends SSLM
> =A0 =A0 =A0 =A0 JmeterKeyStore keys =3D this.getKeyStore();
> =A0 =A0 =A0 =A0 managerFactory.init(null, defaultpw =3D=3D null ? new cha=
r[]{} : defaultpw.toCharArray());
> =A0 =A0 =A0 =A0 KeyManager[] managers =3D managerFactory.getKeyManagers()=
;
> + =A0 =A0 =A0 =A0KeyManager[] newManagers =3D new KeyManager[managers.len=
gth];
> +
> =A0 =A0 =A0 =A0 log.debug(keys.getClass().toString());
>
> =A0 =A0 =A0 =A0 // Now wrap the default managers with our key manager
> =A0 =A0 =A0 =A0 for (int i =3D 0; i < managers.length; i++) {
> =A0 =A0 =A0 =A0 =A0 =A0 if (managers[i] instanceof X509KeyManager) {
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 X509KeyManager manager =3D (X509KeyManage=
r) managers[i];
> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0managers[i] =3D new WrappedX509KeyManage=
r(manager, keys);
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0newManagers[i] =3D new WrappedX509KeyMan=
ager(manager, keys);
> + =A0 =A0 =A0 =A0 =A0 =A0} else {
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0newManagers[i] =3D managers[i];
> =A0 =A0 =A0 =A0 =A0 =A0 }
> =A0 =A0 =A0 =A0 }
>
> @@ -255,7 +259,7 @@ public class JsseSSLManager extends SSLM
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (X509TrustManager)trustmanagers[i=
]);
> =A0 =A0 =A0 =A0 =A0 =A0 }
> =A0 =A0 =A0 =A0 }
> - =A0 =A0 =A0 =A0context.init(managers, trustmanagers, this.rand);
> + =A0 =A0 =A0 =A0context.init(newManagers, trustmanagers, this.rand);
> =A0 =A0 =A0 =A0 if (log.isDebugEnabled()){
> =A0 =A0 =A0 =A0 =A0 =A0 String[] dCiphers =3D context.getSocketFactory().=
getDefaultCipherSuites();
> =A0 =A0 =A0 =A0 =A0 =A0 String[] sCiphers =3D context.getSocketFactory().=
getSupportedCipherSuites();
> @@ -394,4 +398,9 @@ public class JsseSSLManager extends SSLM
> =A0 =A0 =A0 =A0 =A0 =A0 return this.manager.chooseServerAlias(arg0, arg1,=
 arg2);
> =A0 =A0 =A0 =A0 }
> =A0 =A0 }
> +
> + =A0 =A0public static void main(String[] args) {
> + =A0 =A0 =A0 =A0Number[] t =3D new Integer[5];
> + =A0 =A0 =A0 =A0t[0] =3D new Long(123);
> + =A0 =A0}
> =A0}

But I think the example code is not needed !

>
> Modified: jmeter/trunk/xdocs/changes.xml
> URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=3D13=
53205&r1=3D1353204&r2=3D1353205&view=3Ddiff
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- jmeter/trunk/xdocs/changes.xml (original)
> +++ jmeter/trunk/xdocs/changes.xml Sat Jun 23 22:06:21 2012
> @@ -65,6 +65,8 @@ or a Debug Sampler with all fields set t
> =A0<ul>
> =A0<li><bugzilla>53348</bugzilla> - JMeter JMS Point-to-Point Request-Res=
ponse sampler doesn't work when Request-queue and Receive-queue are differe=
nt</li>
> =A0<li><bugzilla>53357</bugzilla> - JMS Point to Point reports too high r=
esponse times in Request Response Mode</li>
> +<li><bugzilla>53440</bugzilla> - SSL connection leads to ArrayStoreExcep=
tion on JDK 6 with some KeyManagerFactory SPI</li>
> +
> =A0</ul>
>
> =A0<h3>Controllers</h3>
>
>