jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1233614 - /jmeter/trunk/test/src/org/apache/jmeter/save/TestSaveService.java
Date Fri, 20 Jan 2012 00:35:45 GMT
On 19 January 2012 22:38,  <pmouawad@apache.org> wrote:
> Author: pmouawad
> Date: Thu Jan 19 22:38:44 2012
> New Revision: 1233614
>
> URL: http://svn.apache.org/viewvc?rev=1233614&view=rev
> Log:
> Commenting test to avoid failure.
> TestLoadAndSave seems wrong as it does not take into account migration.

-1

I don't think that's the correct fix.
It would be better to update the test file to the new settings.
Otherwise, other (incorrect) changes to JMeter might be missed.

> Modified:
>    jmeter/trunk/test/src/org/apache/jmeter/save/TestSaveService.java
>
> Modified: jmeter/trunk/test/src/org/apache/jmeter/save/TestSaveService.java
> URL: http://svn.apache.org/viewvc/jmeter/trunk/test/src/org/apache/jmeter/save/TestSaveService.java?rev=1233614&r1=1233613&r2=1233614&view=diff
> ==============================================================================
> --- jmeter/trunk/test/src/org/apache/jmeter/save/TestSaveService.java (original)
> +++ jmeter/trunk/test/src/org/apache/jmeter/save/TestSaveService.java Thu Jan 19 22:38:44
2012
> @@ -43,7 +43,7 @@ public class TestSaveService extends JMe
>         "ProxyServerTestPlan.jmx",
>         "SimpleTestPlan.jmx",
>         "GuiTest.jmx",
> -        "GuiTest231.jmx",
> +        //"GuiTest231.jmx", Commenting as testLoadAndSave will fails
>         };
>
>     private static final boolean saveOut = JMeterUtils.getPropDefault("testsaveservice.saveout",
false);
>
>

Mime
View raw message