jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1233711 - in /jmeter/trunk: bin/saveservice.properties src/core/org/apache/jmeter/save/SaveService.java
Date Fri, 20 Jan 2012 11:43:47 GMT
On 20 January 2012 06:24, Philippe Mouawad <philippe.mouawad@gmail.com> wrote:
> In my underdstanding, entry should be deleted to avoir
> ClassNotFoundException (as currently tests are failing).

If that were the case, then all the other missing entries would need
to be deleted too.

> In my understanding, if I provide and upgrade then I can remove entry.

No.

> Maybe this part should be documented in a WIKI page.

It's already documented in the file itself that entries should not be removed.

> Regards
> Philippe
>
>
> On Fri, Jan 20, 2012 at 2:51 AM, <sebb@apache.org> wrote:
>
>> Author: sebb
>> Date: Fri Jan 20 01:51:51 2012
>> New Revision: 1233711
>>
>> URL: http://svn.apache.org/viewvc?rev=1233711&view=rev
>> Log:
>> Revert deletion in r1233606; entries should never be deleted
>> Also update property file version
>>
>> Modified:
>>    jmeter/trunk/bin/saveservice.properties
>>    jmeter/trunk/src/core/org/apache/jmeter/save/SaveService.java
>>
>> Modified: jmeter/trunk/bin/saveservice.properties
>> URL:
>> http://svn.apache.org/viewvc/jmeter/trunk/bin/saveservice.properties?rev=1233711&r1=1233710&r2=1233711&view=diff
>>
>> ==============================================================================
>> --- jmeter/trunk/bin/saveservice.properties (original)
>> +++ jmeter/trunk/bin/saveservice.properties Fri Jan 20 01:51:51 2012
>> @@ -18,8 +18,9 @@
>>  ##   limitations under the License.
>>
>>  #---------------------------------------------------------
>> -# N.B. To ensure backward compatibility, please do not
>> -# change or delete any entries that have been used.
>> +
>> +# N.B. To ensure backward compatibility, please do NOT change or delete
>> any entries
>> +
>>  # New entries can be added as necessary.
>>  #
>>  # Note that keys starting with an underscore are special,
>> @@ -39,8 +40,10 @@ _file_version=$Revision$
>>  # (Some version updates were missed here...)
>>  # 2.0 = 2.3.1
>>  # 2.1 = 2.3.2
>> +# (Some version updates were missed here...)
>> +# 2.2 = 2.6
>>  #
>> -_version=2.1
>> +_version=2.2
>>  #
>>  #
>>  # Character set encoding used to read and write JMeter XML files
>> @@ -80,6 +83,7 @@ BSFListener=org.apache.jmeter.visualizer
>>  BSFPreProcessor=org.apache.jmeter.modifiers.BSFPreProcessor
>>  BSFPostProcessor=org.apache.jmeter.extractor.BSFPostProcessor
>>  BSFSampler=org.apache.jmeter.protocol.java.sampler.BSFSampler
>> +BSFSamplerGui=org.apache.jmeter.protocol.java.control.gui.BSFSamplerGui
>>  BSFTimer=org.apache.jmeter.timers.BSFTimer
>>  CacheManager=org.apache.jmeter.protocol.http.control.CacheManager
>>  CacheManagerGui=org.apache.jmeter.protocol.http.gui.CacheManagerGui
>>
>> Modified: jmeter/trunk/src/core/org/apache/jmeter/save/SaveService.java
>> URL:
>> http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/save/SaveService.java?rev=1233711&r1=1233710&r2=1233711&view=diff
>>
>> ==============================================================================
>> --- jmeter/trunk/src/core/org/apache/jmeter/save/SaveService.java
>> (original)
>> +++ jmeter/trunk/src/core/org/apache/jmeter/save/SaveService.java Fri Jan
>> 20 01:51:51 2012
>> @@ -162,7 +162,7 @@ public class SaveService {
>>
>>     // This is written to JMX files by ScriptWrapperConverter
>>     private static String propertiesVersion = "";// read from properties
>> file; written to JMX files
>> -    private static final String PROPVERSION = "2.1";// Expected version
>> $NON-NLS-1$
>> +    private static final String PROPVERSION = "2.2";// Expected version
>> $NON-NLS-1$
>>
>>     // Internal information only
>>     private static String fileVersion = ""; // read from properties file//
>> $NON-NLS-1$
>>
>>
>>
>
>
> --
> Cordialement.
> Philippe Mouawad.

Mime
View raw message