Mailing-List: contact dev-help@jmeter.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jmeter.apache.org
Received-SPF: pass (athena.apache.org: domain of sebbaz@gmail.com designates
 209.85.220.171 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAH9fUpbX3s7_zn-tt1eNZ_Sr983m_Hxp9z_1bb7r-yPaF7dgoA@mail.gmail.com>
References: 
 <CAOGo0VawNSVcx+45C2quugVzSvXKhBw=H5bPUny0jN8yW7kqqw@mail.gmail.com>
	<CAH9fUpbX3s7_zn-tt1eNZ_Sr983m_Hxp9z_1bb7r-yPaF7dgoA@mail.gmail.com>
Date: Sun, 4 Dec 2011 16:41:59 +0000
Message-ID: 
 <CAOGo0VaH=HBD4vjsLnm_fQyvmGn3_91Njo5=gB8mB5FQx3ff5A@mail.gmail.com>
Subject: Re: svn commit: r1209959 - in /jmeter/trunk:
 src/components/org/apache/jmeter/assertions/
 src/components/org/apache/jmeter/config/
 src/components/org/apache/jmeter/extractor/
 src/components/org/apache/jmeter/modifiers/ src/components/org/apache/jmete
From: sebb <sebbaz@gmail.com>
To: dev@jmeter.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On 4 December 2011 16:36, Philippe Mouawad <philippe.mouawad@gmail.com> wro=
te:
> I agree with you it's not great, but don't you think we should keep it
> until we find a better solution ?

We can keep for the short term, but I think the issue needs to be
resolved before the next release.

That is, we need to find a way to do this without file duplication.
Only if that is not possible do we consider whether to keep the
duplicates, in which case we need to find a way to keep them in step
automatically.

> As a user, it feels really strange to have French labels for Popup Menu
> when I switch to English, no ?
>
>
> I will try to find a better solution

OK, but please discuss your proposal on the dev list before applying.

Have a look at JM
> Regards
> Philippe
>
> On Sun, Dec 4, 2011 at 4:10 PM, sebb <sebbaz@gmail.com> wrote:
>
>> On 3 December 2011 17:31, =A0<pmouawad@apache.org> wrote:
>> > Author: pmouawad
>> > Date: Sat Dec =A03 17:31:11 2011
>> > New Revision: 1209959
>> >
>> > URL: http://svn.apache.org/viewvc?rev=3D1209959&view=3Drev
>> > Log:
>> > Bug 52280 - The menu item Options / Choose Language does not change al=
l
>> the displayed text to the new language
>> >
>> > Issue is due to the fact that on a french computer, default locale is
>> fr_FR , so as _en bundles are missing it stays in French. Would be the s=
ame
>> for all non english computers.
>> >
>> > Added:
>> >
>> =A0jmeter/trunk/src/components/org/apache/jmeter/assertions/BSFAssertion=
Resources_en.properties
>> =A0 (with props)
>> >
>> =A0jmeter/trunk/src/components/org/apache/jmeter/assertions/CompareAsser=
tionResources_en.properties
>> =A0 (with props)
>> >
>> =A0jmeter/trunk/src/components/org/apache/jmeter/assertions/JSR223Assert=
ionResources_en.properties
>> =A0 (with props)
>> >
>> =A0jmeter/trunk/src/components/org/apache/jmeter/config/CSVDataSetResour=
ces_en.properties
>> =A0 (with props)
>> >
>> =A0jmeter/trunk/src/components/org/apache/jmeter/config/KeystoreConfigRe=
sources_en.properties
>> =A0 (with props)
>> >
>> =A0jmeter/trunk/src/components/org/apache/jmeter/config/RandomVariableCo=
nfigResources_en.properties
>> =A0 (with props)
>> >
>> =A0jmeter/trunk/src/components/org/apache/jmeter/extractor/BSFPostProces=
sorResources_en.properties
>> =A0 (with props)
>> >
>> =A0jmeter/trunk/src/components/org/apache/jmeter/extractor/BeanShellPost=
ProcessorResources_en.properties
>> =A0 (with props)
>> >
>> =A0jmeter/trunk/src/components/org/apache/jmeter/extractor/DebugPostProc=
essorResources_en.properties
>> =A0 (with props)
>> >
>> =A0jmeter/trunk/src/components/org/apache/jmeter/extractor/JSR223PostPro=
cessorResources_en.properties
>> =A0 (with props)
>> >
>> =A0jmeter/trunk/src/components/org/apache/jmeter/modifiers/BSFPreProcess=
orResources_en.properties
>> =A0 (with props)
>> >
>> =A0jmeter/trunk/src/components/org/apache/jmeter/modifiers/BeanShellPreP=
rocessorResources_en.properties
>> =A0 (with props)
>> >
>> =A0jmeter/trunk/src/components/org/apache/jmeter/modifiers/JSR223PreProc=
essorResources_en.properties
>> =A0 (with props)
>> >
>> =A0jmeter/trunk/src/components/org/apache/jmeter/sampler/DebugSamplerRes=
ources_en.properties
>> =A0 (with props)
>> >
>> =A0jmeter/trunk/src/components/org/apache/jmeter/timers/BSFTimerResource=
s_en.properties
>> =A0 (with props)
>> >
>> =A0jmeter/trunk/src/components/org/apache/jmeter/timers/BeanShellTimerRe=
sources_en.properties
>> =A0 (with props)
>> >
>> =A0jmeter/trunk/src/components/org/apache/jmeter/timers/ConstantThroughp=
utTimerResources_en.properties
>> =A0 (with props)
>> >
>> =A0jmeter/trunk/src/components/org/apache/jmeter/timers/JSR223TimerResou=
rces_en.properties
>> =A0 (with props)
>> >
>> =A0jmeter/trunk/src/components/org/apache/jmeter/timers/SyncTimerResourc=
es_en.properties
>> =A0 (with props)
>> >
>> =A0jmeter/trunk/src/components/org/apache/jmeter/visualizers/BSFListener=
Resources_en.properties
>> =A0 (with props)
>> >
>> =A0jmeter/trunk/src/components/org/apache/jmeter/visualizers/BeanShellLi=
stenerResources_en.properties
>> =A0 (with props)
>> >
>> =A0jmeter/trunk/src/components/org/apache/jmeter/visualizers/JSR223Liste=
nerResources_en.properties
>> =A0 (with props)
>> >
>> =A0jmeter/trunk/src/examples/org/apache/jmeter/examples/testbeans/exampl=
e2/Example2Resources_en.properties
>> =A0 (with props)
>> >
>> =A0jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sample=
r/AccessLogSamplerResources_en.properties
>> =A0 (with props)
>> >
>> =A0jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/sample=
r/JSR223SamplerResources_en.properties
>> =A0 (with props)
>> >
>> =A0jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config=
/DataSourceElementResources_en.properties
>> =A0 (with props)
>> >
>> =A0jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/proces=
sor/JDBCPostProcessorResources_en.properties
>> =A0 (with props)
>> >
>> =A0jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/proces=
sor/JDBCPreProcessorResources_en.properties
>> =A0 (with props)
>> >
>> =A0jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/sample=
r/JDBCSamplerResources_en.properties
>> =A0 (with props)
>>
>> -1
>>
>> I'm not happy with this fix. There are now two copies of the English
>> properties files which have to be kept in step.
>> There has to be a better way to do this. We know that the default
>> property files are in English, so it ought to be possible to chose
>> that instead of _en when switching.
>>
>
>
>
> --
> Cordialement.
> Philippe Mouawad.