jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [Bug 52310] variable in IPSource failed HTTP request if "Concurrent Pool Size" is enabled
Date Sat, 10 Dec 2011 11:43:24 GMT
On 10 December 2011 11:16, Philippe Mouawad <philippe.mouawad@gmail.com> wrote:
> My answers below, but there seem to be an issue as tests are failing.

Yes, strange that adding inheritable has that effect.

We also need a (batch) unit test to expose the original bug.

> Regards
> Philippe
>
> On Sat, Dec 10, 2011 at 12:06 PM, sebb <sebbaz@gmail.com> wrote:
>
>> On 10 December 2011 09:25, Philippe Mouawad <philippe.mouawad@gmail.com>
>> wrote:
>> > Hello Sebb,
>> > Do you suggest we fix it That way ?
>> > I Think it should be ok because to make some post processing and add
>> > variables to context URL need to be called from réal sampler not one in
>> > parallèl download , am I right in this ?
>>
>> That's what I was thinking too.
>>
>> > Do you see other ways of altering jmetercontext from parallèl download ?
>>
>> Cookies? Do these still get stored? Cannot remember off-hand.
>>
> We fixed that by cloning CookieManager and merging afterwards.

Sorry, I meant the optional storing of cookies as variables.

>
>>
>> > Regards
>> > Philippe
>> >
>> > On Saturday, December 10, 2011,  <bugzilla@apache.org> wrote:
>> >> https://issues.apache.org/bugzilla/show_bug.cgi?id=52310
>> >>
>> >> --- Comment #3 from Sebb <sebb@apache.org> 2011-12-10 01:00:19 UTC
---
>> >> (In reply to comment #2)
>> >>> The issue is due to the fact the property is cached in JMeterContext
>> > which is
>> >>> thread local in Parent thread of Parallel Download threads.
>> >>> Quick fix would be to make ThreadLocal InheritableThreadLocal but as
>> >>> JMeterContext is not thread-safe it is not the right fix.
>> >>
>> >> If the context is not mutated, then it should be OK to share.
>> >>
>> >> --
>> >> Configure bugmail:
>> > https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
>> >> ------- You are receiving this mail because: -------
>> >> You are the assignee for the bug.
>> >>
>> >
>> > --
>> > Cordialement.
>> > Philippe Mouawad.
>>
>
>
>
> --
> Cordialement.
> Philippe Mouawad.

Mime
View raw message