Mailing-List: contact dev-help@jmeter.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jmeter.apache.org
Received-SPF: pass (nike.apache.org: domain of sebbaz@gmail.com designates
 209.85.212.43 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAH9fUpaEPL4CYNK1KBrC5j8vH2z9AVfnah8TW0uWHVn1iokjjg@mail.gmail.com>
References: 
 <CAH9fUpaTw3p17XmsH+68wPsHKDNwdBB-diZKntmWQKDtYz8bEw@mail.gmail.com>
	<CAOGo0VYVvEhEWj699tVJEC93zZg9eowWN66esH-rURoiJb06rA@mail.gmail.com>
	<CAH9fUpaEPL4CYNK1KBrC5j8vH2z9AVfnah8TW0uWHVn1iokjjg@mail.gmail.com>
Date: Wed, 30 Nov 2011 22:17:29 +0000
Message-ID: 
 <CAOGo0VYDdjL3s_KuV7To89rcf5FBSTiM0m2wj23dch+cy+G6_g@mail.gmail.com>
Subject: Re: Question about StandardJMeterEngine#engine
From: sebb <sebbaz@gmail.com>
To: dev@jmeter.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On 30 November 2011 21:57, Philippe Mouawad <philippe.mouawad@gmail.com> wr=
ote:
> Thanks for answers, see below
>
> On Wed, Nov 30, 2011 at 10:53 PM, sebb <sebbaz@gmail.com> wrote:
>
>> On 30 November 2011 20:57, Philippe Mouawad <philippe.mouawad@gmail.com>
>> wrote:
>> > Hello,
>> > Do you see any reason for engine field being static ?
>>
>> As per the comments:
>>
>> =A0 =A0// Allow engine and threads to be stopped from outside a thread
>> =A0 =A0// e.g. from beanshell server
>> =A0 =A0// Assumes that there is only one instance of the engine
>> =A0 =A0// at any one time so it is not guaranteed to work ...
>>
>> > =A0 - All static methods that use it are not called anywhere
>>
>> BeanShell scripts use introspection to get access.
>>
> Where can I find current users of this ? (to see if I can change it )

Impossible to find all existing uses.
Anyone can write a script that uses any public method.
Any change in binary compatibility can potentially cause a script to fail.

However, check the documentation and sample scripts.
That will give an idea as to what users might reasonably expect to be
able to use.

>> > =A0 - askThreadsToStop could just call stopTest(false)
>>
>> Yes, I think it could.
>>
>> >
>> > I think field should be removed to make code cleaner.
>>
>> Only if an alternative way can be found to allow scripts to access the
>> engine.
>> But would probably still need to keep the static methods, at least for a
>> while.
>>
>> > Regards.
>> > Philippe.
>>
>
>
>
> --
> Cordialement.
> Philippe Mouawad.