jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1206864 - /jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/sampler/BeanShellSampler.java
Date Sun, 27 Nov 2011 23:27:38 GMT
On 27 November 2011 22:09,  <pmouawad@apache.org> wrote:
> Author: pmouawad
> Date: Sun Nov 27 22:09:05 2011
> New Revision: 1206864
>
> URL: http://svn.apache.org/viewvc?rev=1206864&view=rev
> Log:
> Make field volatile to ensure Serializable contract

[I think you meant transient; it was already volatile.]

Just wondering how you found this problem?
And I wonder why the serialisation tests did not find it.

> Modified:
>    jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/sampler/BeanShellSampler.java
>
> Modified: jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/sampler/BeanShellSampler.java
> URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/sampler/BeanShellSampler.java?rev=1206864&r1=1206863&r2=1206864&view=diff
> ==============================================================================
> --- jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/sampler/BeanShellSampler.java
(original)
> +++ jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/sampler/BeanShellSampler.java
Sun Nov 27 22:09:05 2011
> @@ -48,7 +48,7 @@ public class BeanShellSampler extends Be
>
>     public static final String RESET_INTERPRETER = "BeanShellSampler.resetInterpreter";
//$NON-NLS-1$
>
> -    private volatile BeanShellInterpreter savedBsh = null;
> +    private transient volatile BeanShellInterpreter savedBsh = null;
>
>     @Override
>     protected String getInitFileProperty() {
>
>
>

Mime
View raw message