jena-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From a...@apache.org
Subject [2/2] jena git commit: Tidy javadoc and comments
Date Wed, 01 Aug 2018 21:06:59 GMT
Tidy javadoc and comments


Project: http://git-wip-us.apache.org/repos/asf/jena/repo
Commit: http://git-wip-us.apache.org/repos/asf/jena/commit/6dac178f
Tree: http://git-wip-us.apache.org/repos/asf/jena/tree/6dac178f
Diff: http://git-wip-us.apache.org/repos/asf/jena/diff/6dac178f

Branch: refs/heads/master
Commit: 6dac178f813239f9d7145f03b1538b0dcb289295
Parents: a8a3ce4
Author: Andy Seaborne <andy@apache.org>
Authored: Wed Aug 1 22:06:47 2018 +0100
Committer: Andy Seaborne <andy@apache.org>
Committed: Wed Aug 1 22:06:47 2018 +0100

----------------------------------------------------------------------
 .../src/main/java/org/apache/jena/sparql/expr/NodeValue.java   | 6 ++----
 jena-cmds/src/main/java/arq/cmdline/ModAssembler.java          | 1 +
 2 files changed, 3 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/jena/blob/6dac178f/jena-arq/src/main/java/org/apache/jena/sparql/expr/NodeValue.java
----------------------------------------------------------------------
diff --git a/jena-arq/src/main/java/org/apache/jena/sparql/expr/NodeValue.java b/jena-arq/src/main/java/org/apache/jena/sparql/expr/NodeValue.java
index 718a973..d1c2317 100644
--- a/jena-arq/src/main/java/org/apache/jena/sparql/expr/NodeValue.java
+++ b/jena-arq/src/main/java/org/apache/jena/sparql/expr/NodeValue.java
@@ -585,13 +585,11 @@ public abstract class NodeValue extends ExprNode
      *  Supports &lt;, &lt;=, &gt;, &gt;= but not = nor != (which are sameValueAs
and notSameValueAs)
      * @param nv1
      * @param nv2
-     * @return negative, 0 , or positive for not possible, less than, equal, greater than.
+     * @return Expr.CMP_INDETERMINATE(+2), Expr.CMP_LESS(-1), Expr.CMP_EQUAL(0) or Expr.CMP_GREATER(+1)
      * @throws ExprNotComparableException  
      */
     public static int compare(NodeValue nv1, NodeValue nv2)
     {
-        // Called from E_LessThat etc
-        // and NodeUtils.comparLiteralsByValue 
         if ( nv1 == null || nv2 == null )
             //raise(new ExprEvalException("Attempt to notSameValueAs on null") ;
             throw new ARQInternalErrorException("Attempt to compare on null") ;
@@ -622,7 +620,7 @@ public abstract class NodeValue extends ExprNode
         ValueSpaceClassification compType = classifyValueOp(nv1, nv2) ;
         
         // Special case - date/dateTime comparison is affected by timezones and may be
-        // interdeterminate based on the value of the dateTime/date.
+        // indeterminate based on the value of the dateTime/date.
         // Do this first, 
         
         switch (compType)

http://git-wip-us.apache.org/repos/asf/jena/blob/6dac178f/jena-cmds/src/main/java/arq/cmdline/ModAssembler.java
----------------------------------------------------------------------
diff --git a/jena-cmds/src/main/java/arq/cmdline/ModAssembler.java b/jena-cmds/src/main/java/arq/cmdline/ModAssembler.java
index 30e4573..072c954 100644
--- a/jena-cmds/src/main/java/arq/cmdline/ModAssembler.java
+++ b/jena-cmds/src/main/java/arq/cmdline/ModAssembler.java
@@ -34,6 +34,7 @@ import org.apache.jena.sparql.core.assembler.AssemblerUtils ;
 public class ModAssembler extends ModBase
 {
     public static final ArgDecl assemblerDescDecl = new ArgDecl(ArgDecl.HasValue, "desc",
"dataset") ;
+    
     private String assemblerFile = null ;
     Object thingDescribed = null ;
     


Mime
View raw message