jena-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From a...@apache.org
Subject [3/3] jena git commit: Comments.
Date Mon, 16 Jan 2017 22:43:39 GMT
Comments.

Project: http://git-wip-us.apache.org/repos/asf/jena/repo
Commit: http://git-wip-us.apache.org/repos/asf/jena/commit/d7d37d61
Tree: http://git-wip-us.apache.org/repos/asf/jena/tree/d7d37d61
Diff: http://git-wip-us.apache.org/repos/asf/jena/diff/d7d37d61

Branch: refs/heads/master
Commit: d7d37d61402018508d5c6a72ad405da5a53c8dde
Parents: 6cd8389
Author: Andy Seaborne <andy@apache.org>
Authored: Mon Jan 16 22:43:08 2017 +0000
Committer: Andy Seaborne <andy@apache.org>
Committed: Mon Jan 16 22:43:08 2017 +0000

----------------------------------------------------------------------
 .../java/org/apache/jena/sparql/algebra/TestClassify.java    | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/jena/blob/d7d37d61/jena-arq/src/test/java/org/apache/jena/sparql/algebra/TestClassify.java
----------------------------------------------------------------------
diff --git a/jena-arq/src/test/java/org/apache/jena/sparql/algebra/TestClassify.java b/jena-arq/src/test/java/org/apache/jena/sparql/algebra/TestClassify.java
index 7cea0a2..6e53804 100644
--- a/jena-arq/src/test/java/org/apache/jena/sparql/algebra/TestClassify.java
+++ b/jena-arq/src/test/java/org/apache/jena/sparql/algebra/TestClassify.java
@@ -40,9 +40,9 @@ public class TestClassify extends BaseTest
 	{ classifyJ("{?s :p :o . { ?s :p ?o FILTER(?o) } }", true) ; }
 
     // JENA-1167
-    // This actually safe in thsi case but as general component.
+    // This actually safe in this case but as general component.
     // the JoinClassifier is not clever enough to know that ?o is completely
-    // unbound. It may be boudn bu whatever feeds into the potential sequence.
+    // unbound. It may be bound by whatever feeds into the potential sequence.
     @Test public void testClassify_Join_04() 
 	{ classifyJ("{?s :p :o . { ?s :p :o FILTER(?o) } }", false) ; }
 
@@ -80,6 +80,7 @@ public class TestClassify extends BaseTest
 	@Test public void testClassify_Join_13() 
 	{ classifyJ("{?s :p :o . { ?x :p :o OPTIONAL { :s :p :o FILTER(?x) } } }", true) ; }
 
+	// See testClassify_Join_04()
 	@Test public void testClassify_Join_14() 
 	{ classifyJ("{?s :p :o . { OPTIONAL { :s :p :o FILTER(?o) } } }", false) ; }
 
@@ -102,7 +103,8 @@ public class TestClassify extends BaseTest
     @Test public void testClassify_Join_31() 
     { classifyJ("{ ?x ?y ?z {SELECT ?s { ?s ?p ?o} } }", true) ; }
 
-    // JENA-1167 : Use of a filter variable not in from the LHS
+    // JENA-1167 : Use of a filter variable not in the LHS
+    // Could be safe but the optimizer is not spotting it. 
     @Test public void testClassify_Join_32() 
     { classifyJ("{ GRAPH ?g { ?x ?y ?z } { FILTER (?a) } }", false) ; }
 


Mime
View raw message