jena-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From a...@apache.org
Subject svn commit: r1511666 - /jena/trunk/jena-arq/src/main/java/com/hp/hpl/jena/sparql/algebra/optimize/Optimize.java
Date Thu, 08 Aug 2013 10:13:25 GMT
Author: andy
Date: Thu Aug  8 10:13:24 2013
New Revision: 1511666

URL: http://svn.apache.org/r1511666
Log:
Update comment on simplification.

Modified:
    jena/trunk/jena-arq/src/main/java/com/hp/hpl/jena/sparql/algebra/optimize/Optimize.java

Modified: jena/trunk/jena-arq/src/main/java/com/hp/hpl/jena/sparql/algebra/optimize/Optimize.java
URL: http://svn.apache.org/viewvc/jena/trunk/jena-arq/src/main/java/com/hp/hpl/jena/sparql/algebra/optimize/Optimize.java?rev=1511666&r1=1511665&r2=1511666&view=diff
==============================================================================
--- jena/trunk/jena-arq/src/main/java/com/hp/hpl/jena/sparql/algebra/optimize/Optimize.java
(original)
+++ jena/trunk/jena-arq/src/main/java/com/hp/hpl/jena/sparql/algebra/optimize/Optimize.java
Thu Aug  8 10:13:24 2013
@@ -138,7 +138,8 @@ public class Optimize implements Rewrite
         
         if ( false )
         {
-            // Simplify is always applied by the AlgebraGenerator
+            // Removal of "group of one" join (AKA SPARQL "simplification") 
+            // is done during algebra generation in AlgebraGenerator
             op = apply("Simplify", new TransformSimplify(), op) ;
             op = apply("Delabel", new TransformRemoveLabels(), op) ;
         }
@@ -149,11 +150,6 @@ public class Optimize implements Rewrite
         // This transformation must be done (e.g. by QueryEngineBase) if no other optimization
is done. 
         op = TransformScopeRename.transform(op) ;
         
-        // Remove "group of one" join
-        // Done in AlgebraGenerator
-        // e..g CONSTRUCT {} WHERE { SELECT ... } 
-        //op = TransformTopLevelSelect.simplify(op) ;
-        
         // Prepare expressions.
         OpWalker.walk(op, new OpVisitorExprPrepare(context)) ;
         



Mime
View raw message