jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] Implement ServerWithNatRuleToNodeMetadata Function (#428)
Date Fri, 13 Apr 2018 07:23:28 GMT
nacx commented on this pull request.

Thanks @btrishkin! Just one minor comment left. Apart from that, LGTM!

> + */
+package org.jclouds.dimensiondata.cloudcontrol.compute.functions;
+
+import com.google.common.base.Function;
+import com.google.inject.Singleton;
+import org.jclouds.compute.domain.OperatingSystem;
+
+import javax.annotation.Nullable;
+
+@Singleton
+public class OperatingSystemToOperatingSystem
+      implements Function<org.jclouds.dimensiondata.cloudcontrol.domain.OperatingSystem,
OperatingSystem> {
+
+   private final OperatingSystemToOsFamily operatingSystemToOsFamily;
+
+   public OperatingSystemToOperatingSystem(final OperatingSystemToOsFamily operatingSystemToOsFamily)
{

Add the `@Inject` annotation here and remove the public modifier from the constructor.

> + */
+package org.jclouds.dimensiondata.cloudcontrol.compute.functions;
+
+import com.google.common.base.Function;
+import com.google.inject.Singleton;
+import org.jclouds.compute.domain.OperatingSystem;
+
+import javax.annotation.Nullable;
+
+@Singleton
+public class OperatingSystemToOperatingSystem
+      implements Function<org.jclouds.dimensiondata.cloudcontrol.domain.OperatingSystem,
OperatingSystem> {
+
+   private final OperatingSystemToOsFamily operatingSystemToOsFamily;
+
+   public OperatingSystemToOperatingSystem(final OperatingSystemToOsFamily operatingSystemToOsFamily)
{

Add the `@Inject` annotation and remove the public modifier from the constructor to make it
package private ([background](https://github.com/google/guice/wiki/KeepConstructorsHidden)).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/428#pullrequestreview-111906667
Mime
View raw message