Mailing-List: contact notifications-help@jclouds.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jclouds.apache.org
Date: Mon, 26 Sep 2016 07:04:45 -0700
From: Ignasi Barrera <notifications@github.com>
Reply-To: jclouds/jclouds <reply+004376fa0689a38e6fd5d94287ec4b0d263d0d7274377caf92cf000000011400ecfd92a169ce0aadf06a@reply.github.com>
To: jclouds/jclouds <jclouds@noreply.github.com>
Message-ID: <jclouds/jclouds/pull/1014/c249578664@github.com>
In-Reply-To: <jclouds/jclouds/pull/1014@github.com>
References: <jclouds/jclouds/pull/1014@github.com>
Subject: Re: [jclouds/jclouds] rename oauth properties (#1014)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_57e92afd60984_102c3f91e842129c1995c7";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 26 Sep 2016 14:05:00 -0000

----==_mimepart_57e92afd60984_102c3f91e842129c1995c7
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

Well, I'd say the wrong properties are the ones you point in this last comment, as they double-prefix the property. When jclouds creates the context, it tries to resolve the properties that are prefixed with the "provider id", and if not, it tries to resolve them with the "jclouds" prefix. You can see how this is done [here](https://github.com/jclouds/jclouds/blob/master/core/src/main/java/org/jclouds/ContextBuilder.java#L414).

This allows users to configure the same properties with different values for different providers, which is desirable if you run one single app that consumes several apis; the "identity" property should be different for each connection. Apart from the override properties, jclouds loads all properties prefixed with "jclouds" or the "provider id" that are configured as systme properties (see [here](https://github.com/jclouds/jclouds/blob/master/core/src/main/java/org/jclouds/ContextBuilder.java#L373)), so you can have global configuration variables for all providers.

So, in this case, "oauth" is the prefix, designating the endpoint the oauth api uses. It would not be correct to double-prefix it as "jclouds.oauth".

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1014#issuecomment-249578664
----==_mimepart_57e92afd60984_102c3f91e842129c1995c7
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<p>Well, I'd say the wrong properties are the ones you point in this last c=
omment, as they double-prefix the property. When jclouds creates the contex=
t, it tries to resolve the properties that are prefixed with the "provider =
id", and if not, it tries to resolve them with the "jclouds" prefix. You ca=
n see how this is done <a href=3D"https://github.com/jclouds/jclouds/blob/m=
aster/core/src/main/java/org/jclouds/ContextBuilder.java#L414">here</a>.</p>

<p>This allows users to configure the same properties with different values=
 for different providers, which is desirable if you run one single app that=
 consumes several apis; the "identity" property should be different for eac=
h connection. Apart from the override properties, jclouds loads all propert=
ies prefixed with "jclouds" or the "provider id" that are configured as sys=
tme properties (see <a href=3D"https://github.com/jclouds/jclouds/blob/mast=
er/core/src/main/java/org/jclouds/ContextBuilder.java#L373">here</a>), so y=
ou can have global configuration variables for all providers.</p>

<p>So, in this case, "oauth" is the prefix, designating the endpoint the oa=
uth api uses. It would not be correct to double-prefix it as "jclouds.oauth=
".</p>

<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&mda=
sh;<br />You are receiving this because you are subscribed to this thread.<=
br />Reply to this email directly, <a href=3D"https://github.com/jclouds/jc=
louds/pull/1014#issuecomment-249578664">view it on GitHub</a>, or <a href=
=3D"https://github.com/notifications/unsubscribe-auth/AEN2-mdguTsTsI0jzRHCf=
gQTjQqMdIvAks5qt9D9gaJpZM4KGRto">mute the thread</a>.<img alt=3D"" height=
=3D"1" src=3D"https://github.com/notifications/beacon/AEN2-s3z0u62tzyTdOYVW=
EhQkOdCem0Nks5qt9D9gaJpZM4KGRto.gif" width=3D"1" /></p>
<div itemscope itemtype=3D"http://schema.org/EmailMessage">
<div itemprop=3D"action" itemscope itemtype=3D"http://schema.org/ViewAction=
">
  <link itemprop=3D"url" href=3D"https://github.com/jclouds/jclouds/pull/10=
14#issuecomment-249578664"></link>
  <meta itemprop=3D"name" content=3D"View Pull Request"></meta>
</div>
<meta itemprop=3D"description" content=3D"View this Pull Request on GitHub"=
></meta>
</div>

<script type=3D"application/json" data-scope=3D"inboxmarkup">{"api_version"=
:"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"Gi=
tHub"},"entity":{"external_key":"github/jclouds/jclouds","title":"jclouds/j=
clouds","subtitle":"GitHub repository","main_image_url":"https://cloud.gith=
ubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7b=
b5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/1434=
18/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Ope=
n in GitHub","url":"https://github.com/jclouds/jclouds"}},"updates":{"snipp=
ets":[{"icon":"PERSON","message":"@nacx in #1014: Well, I'd say the wrong p=
roperties are the ones you point in this last comment, as they double-prefi=
x the property. When jclouds creates the context, it tries to resolve the p=
roperties that are prefixed with the \"provider id\", and if not, it tries =
to resolve them with the \"jclouds\" prefix. You can see how this is done [=
here](https://github.com/jclouds/jclouds/blob/master/core/src/main/java/org=
/jclouds/ContextBuilder.java#L414).\r\n\r\nThis allows users to configure t=
he same properties with different values for different providers, which is =
desirable if you run one single app that consumes several apis; the \"ident=
ity\" property should be different for each connection. Apart from the over=
ride properties, jclouds loads all properties prefixed with \"jclouds\" or =
the \"provider id\" that are configured as systme properties (see [here](ht=
tps://github.com/jclouds/jclouds/blob/master/core/src/main/java/org/jclouds=
/ContextBuilder.java#L373)), so you can have global configuration variables=
 for all providers.\r\n\r\nSo, in this case, \"oauth\" is the prefix, desig=
nating the endpoint the oauth api uses. It would not be correct to double-p=
refix it as \"jclouds.oauth\"."}],"action":{"name":"View Pull Request","url=
":"https://github.com/jclouds/jclouds/pull/1014#issuecomment-249578664"}}}<=
/script>=

----==_mimepart_57e92afd60984_102c3f91e842129c1995c7--