Return-Path: Delivered-To: apmail-james-server-dev-archive@www.apache.org Received: (qmail 45896 invoked from network); 21 Aug 2010 20:09:24 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 21 Aug 2010 20:09:24 -0000 Received: (qmail 35978 invoked by uid 500); 21 Aug 2010 20:09:24 -0000 Delivered-To: apmail-james-server-dev-archive@james.apache.org Received: (qmail 35840 invoked by uid 500); 21 Aug 2010 20:09:23 -0000 Mailing-List: contact server-dev-help@james.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "James Developers List" Reply-To: "James Developers List" Delivered-To: mailing list server-dev@james.apache.org Received: (qmail 35826 invoked by uid 99); 21 Aug 2010 20:09:23 -0000 Received: from Unknown (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 21 Aug 2010 20:09:23 +0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of norman.maurer@googlemail.com designates 209.85.212.49 as permitted sender) Received: from [209.85.212.49] (HELO mail-vw0-f49.google.com) (209.85.212.49) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 21 Aug 2010 20:09:02 +0000 Received: by vws11 with SMTP id 11so4512047vws.22 for ; Sat, 21 Aug 2010 13:08:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:content-type; bh=6emBxcC644m+OhpMJ83JZhB4UUCkkGWCFGbmKRNtzxQ=; b=bUboEjsFUOOeLoat5p8mgtjuyz2bTU8nuVj/SlTg9/tCx70EpWo3TqKuN9BcggMy29 Tv1eHJUUbU28PeyP5YoLiZIVZ+aLszu+AAWAZAA5062l2C/Ts6M6wHvWbbDY/d0BHLuI EZChOcnqR27EM2PQQd4eSxiYOIf5uWAjK2wF8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type; b=WJbOpq4Ye62hJI4sK9N7e0KtL4BPjgoB0DyZ6XoKtSsw3TshDWJcvk2rlSKI8vaJf1 Qy34d67UWApgWZ7RQvVzLFwjNiuwslngFClRxQOGIO6bn4gMTExp3SfGHRB7jWim3q5u uIIHr8Qlm58YfPK+w7i7AXw+0bQnO3rqmh8G4= MIME-Version: 1.0 Received: by 10.220.158.9 with SMTP id d9mr1803934vcx.250.1282421320075; Sat, 21 Aug 2010 13:08:40 -0700 (PDT) Sender: norman.maurer@googlemail.com Received: by 10.220.50.100 with HTTP; Sat, 21 Aug 2010 13:08:39 -0700 (PDT) In-Reply-To: References: <1282380308.3940.11.camel@TimPad> Date: Sat, 21 Aug 2010 22:08:39 +0200 X-Google-Sender-Auth: clVjp-mf7lA05Zfqj9Ny1Q1sMyE Message-ID: Subject: Re: [IMAP] Remove org.apache.james.imap.store.Subscriper From: Norman Maurer To: James Developers List Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Checked: Checked by ClamAV on apache.org Ok another attempt was made.. please review changes made in revision 987821 Thx, Norman 2010/8/21 Norman Maurer : > Well I need to revert it ;) I will do so then.. > > Bye, > Norman > > > 2010/8/21 Norman Maurer : >> Hi Tim, >> >> comments inside.. >> >> 2010/8/21 Tim-Christian Mundt : >>> Norman, >>> >>> you are right in that it was kinda double, so there should be some >>> cleanup. My first attempt would have been to remove the subscription >>> stuff from the MailboxManager (your option #1). The reason is that we >>> always have a manager and its respective mapper. Now we have the >>> MailboxManager with two Mappers. I think we should also merge them which >>> would also simplify the package structure because we wouldn't need >>> the .mail and .user packages anymore. >> >> Thats true I just thought it would be more easy to have not to many >> interfaces to implement. Anyway I would also be happy to move the >> subscripe stuff to any extra interface. I just don't like to have it >> duplicated so feel free to revert... >> >>> >>> One more thing concerning naming and stuff: Now the >>> DelegatingMailboxManager is not really delegating anymore. Is there any >>> good reason we should keep it separate from StoreMailboxManager? If not >>> I'd rather have a little bigger class but fewer hierarchy levels. >> >> I need to review.. >> >>> >>> Any thoughts? >>> >>> Tim >>> >>> Am Samstag, den 21.08.2010, 10:23 +0200 schrieb Norman Maurer: >>>> I just committed the changes.. If anyone thinks its a bad idea we can >>>> revert it anyway.. >>>> >>>> https://issues.apache.org/jira/browse/IMAP-205 >>>> >>>> Bye, >>>> Norman >>>> >>>> 2010/8/21 Norman Maurer : >>>> > Hi there, >>>> > >>>> > after looking again at the IMAP api I'm in favor of removing the >>>> > org.apache.james.imap.store.Subscriper interface and merge the >>>> > implementations with the MailboxManager implementations. Thats because >>>> > the Subsciper interface has 3 methods, all of the methods are already >>>> > in MailboxManager. So the MailboxManager just wraps the Subscriper >>>> > implementation and delegate the call to it. >>>> > >>>> > So there are two solutions to this: >>>> > >>>> > 1) Remove the methods from MailboxManager and move the Subscriper >>>> > interface to the mailbox api >>>> > 2) Remove the Subscriper interface from store api and merge the implementations >>>> > >>>> > As I stated before I would prefer 2). >>>> > >>>> > WDYT ? >>>> > >>>> > Bye, >>>> > Norman >>>> > >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org >>>> For additional commands, e-mail: server-dev-help@james.apache.org >>>> >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org >>> For additional commands, e-mail: server-dev-help@james.apache.org >>> >>> >> >> Bye, >> Norman >> > --------------------------------------------------------------------- To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org For additional commands, e-mail: server-dev-help@james.apache.org