james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guru Shenoy" <gshe...@gamebox.net>
Subject DNSServer bug
Date Fri, 18 Nov 2005 20:30:28 GMT
hi, 
   I was looking at the DNSServer.java codebase and saw what looks like a bug. In the findMXRecords(...)
function i notice the code doing a dns lookup on failure to lookup MX records. But there is
no statement to return the server object populated with hostname on success of the dns lookup.
I propose the following fix. 

 svn diff DNSServer.java
Index: DNSServer.java
===================================================================
--- DNSServer.java      (revision 345560)
+++ DNSServer.java      (working copy)
@@ -249,6 +249,7 @@
                     try {
                         getByName(hostname);
                         servers.add(hostname);
+                        return Collections.unmodifiableCollection(servers);
                     } catch (UnknownHostException uhe) {
                         // The original domain name is not a valid host,
                         // so we can't add it to the server list.  In this


thanks
guru
Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message