james-mime4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefano Bagnara <apa...@bago.org>
Subject Re: svn commit: r1481814
Date Mon, 13 May 2013 19:22:49 GMT
2013/5/13 Oleg Kalnichevski <olegk@apache.org>:
>> Make sense. I admit I've never cared about resource management in
>> tests (the JVM free them shutting down).
> Test cases can be run as a part of a larger test suite inside the same
> JVM and impact other tests. Sloppy resource management is simply a bad
> idea no matter the context.

Sure. I wrote "Make sense" ;-)

>> IIRC the testsuite declaration as a nested class and the code
>> duplication was needed in order to be able to run single tests in
>> Eclipse (and maybe in maven, but I don't remember the exact scope of
>> this statement). So I guess that extracting the common code could have
>> broken this feature (unfortunately I don't have eclipse on this
>> computer right now).
>> [...]

> Still works for me. I can still run the test for individual messages in
> Eclipse after refactoring.

Great! Maybe junit 4 is better, then, and we don't need that hacks anymore!!

Thank you,

View raw message