james-mime4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oleg Kalnichevski <ol...@apache.org>
Subject [PATCH] 1.5 compatibility; was Re: Issues in Axiom after recent changes in MIME4J
Date Wed, 24 Apr 2013 14:27:34 GMT
On Wed, 2013-04-24 at 09:47 +0300, Ioan Eugen Stan wrote:
> Hi Oleg,
> I re-factored the code and switched to Java 1.6 language (for-each,
> @Overrides, etc). I didn't expect to cause a mess. I didn't expect
> people to still require Java 1.5 since it's EOL for such a long time.
> There is no right answer to your question, I don't particularly like
> having different requirements. On the other hand, I favor moving
> forward, although I also recognize the need to maintain compatibility
> to older platforms. Ideally we can solve that problem if we ensure
> that some branches (like 0.7.x) require Java 1.5, while in new
> releases we can require a different Java version if needed. This has
> the disadvantage that it will put a harder burden on maintenance.
> In our case we can require Java 1.5 for mime4j-core. For dom we can
> keep 1.6 or do some work to revert back.
> Cheers,

It is not about expecting people to use older versions of JRE but rather
providing a reasonable level of compatibility. We can build against 1.5
and at the same time to recommend users to run 1.6 or newer. Upgrading
to 1.6 buys us almost nothing (the only nice to have functionality I can
think of is String constructors taking charset as java.nio.Charset
instead of String).

I am attaching a patch for your review that restores full 1.5
compatibility. The changes, as you can see, are very minor and affect
only three classes. I also had to downgrade Commons IO to version 2.2
but as it turned out we are not using any new functionality at all. So,
I do not see this as a loss.

If I hear no objections I'll commit the patch in a few days. So, please
complain loudly if you find anything disagreeable.


View raw message