Mailing-List: contact mime4j-dev-help@james.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mime4j-dev@james.apache.org
Received-SPF: pass (athena.apache.org: domain of robertburrelldonkin@gmail.com
 designates 209.85.218.217 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=CvREG4KPM9LxlKsP6DTnolhWqApjsu8JKtAKxwTTpS763xwQnIs5IoR1Dl+pzGpSDX
         0QL0qbfCnxCwmxFgc5hsymRFNL99qUiOWMPUrN4GsJewJ1/oKZtVu+beUXAtXddxr7A2
         noM7e5gkicqp9M3qOBDBoiDDDoyJ7CgWEEgFs=
MIME-Version: 1.0
In-Reply-To: <4A8B125C.1070809@apache.org>
References: <fb8c73b30908180603m7a83024eld9196da863a26ef0@mail.gmail.com>
	 <a92573960908181211g306e54dbt8981372c43a6f3e6@mail.gmail.com>
	 <4A8B125C.1070809@apache.org>
Date: Tue, 18 Aug 2009 22:26:04 +0100
Message-ID: <f470f68e0908181426w2436251dp72ea457c60d1cbb8@mail.gmail.com>
Subject: Re: Soft line breaks in quoted printable decoding
From: Robert Burrell Donkin <robertburrelldonkin@gmail.com>
To: mime4j-dev@james.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

On Tue, Aug 18, 2009 at 9:43 PM, Oleg Kalnichevski<olegk@apache.org> wrote:
> Markus Wiederkehr wrote:
>>
>> On Tue, Aug 18, 2009 at 3:03 PM, Alejandro
>> Valdez<alejandro.valdez@gmail.com> wrote:
>>>
>>> Hi list, I noticed that the class QuotedPrintableInputStream expects
>>> that the input stream is encoded using CRLF as line terminator (in
>>> particular, when dealing with quoted printable soft line breaks), but
>>> I have found that some e-mails are encoded using LF as line
>>> terminator. In such cases QuotedPrintableInputStream leaves in the
>>> decoded output a =LF for each line with a soft line break.
>>>
>>> I tried to find what RFC specifies that a mime e-mail should uses CRLF
>>> as line terminator, but I could not find it...
>>>
>>> I patched my QuotedPrintableInputStream class to identify =LF as a
>>> soft line break, it works ok, but maybe I missing something.
>>
>> Lines have to be terminated with CRLF if a message is transmitted via
>> SMTP (see RFC 5321 section 2.3.8.).
>>
>> As far as I know this only applies when the message is transferred. It
>> does not apply to the message itself, e.g. when it is stored on disk.
>>
>> So QuotedPrintableInputStream should probably accept other line endings I
>> guess.
>>
>> Other opinions?
>>
>> Markus
>
>
> I think QuotedPrintableInputStream should be lenient about line breaks and
> treat both CRLF and lone LF as valid line breaks.
>
> I am still planning to review (and possibly rewrite most of)
> QuotedPrintableInputStream class in order to address MIME4J-103 [1]. I could
> tackle the line break issue at the same time. I just do not know when I may
> get around to doing that.

cool

are there any volunteers out there who might be able to find time to
take this on (with oleg's help, of course ;-)?

- robert