Mailing-List: contact mime4j-dev-help@james.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mime4j-dev@james.apache.org
Received-SPF: pass (athena.apache.org: domain of markus.wiederkehr@gmail.com
 designates 209.85.218.219 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=SHJxZaCtn4uyNbOFRfr/YEzLJpOJ+vVFqi0aaybeGKb4/PEXEt3UA5mE0k7/P1xj9Y
         xEPXU0OVgsB/GBrMNUfBR/qoyklzAdmaY52rL9WpOJak6j8/CHAZgs+EN3c/xozbMuIW
         BaFrRTNDNu2oHmJvUwjslSx1wtLQrb6QKIZBY=
MIME-Version: 1.0
In-Reply-To: <4A2CE387.30200@bago.org>
References: <20090525170226.34711238888D@eris.apache.org>
	 <4A22C897.4080800@bago.org>
	 <a92573960906061427s18897e63u10916287957c43eb@mail.gmail.com>
	 <4A2CE387.30200@bago.org>
Date: Mon, 8 Jun 2009 16:19:10 +0200
Message-ID: <a92573960906080719k3c3d8736l4566a999ccc5d5d0@mail.gmail.com>
Subject: Re: svn commit: r778453 - in /james/mime4j/trunk/core/src:
	main/java/org/apache/james/mime4j/message/
 test/java/org/apache/james/mime4j/message/
From: Markus Wiederkehr <markus.wiederkehr@gmail.com>
To: mime4j-dev@james.apache.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 8, 2009 at 12:10 PM, Stefano Bagnara<apache@bago.org> wrote:
> Markus Wiederkehr ha scritto:
>> On Sun, May 31, 2009 at 8:12 PM, Stefano Bagnara<apache@bago.org> wrote:
>>> mwiederkehr@apache.org ha scritto:
>>>> Author: mwiederkehr
>>>> Date: Mon May 25 17:02:25 2009
>>>> New Revision: 778453
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=3D778453&view=3Drev
>>>> Log:
>>>> MIME4J-136: Pull up getInputStream() from BinaryBody to SingleBody
>>>> [....]
>>>> Modified: james/mime4j/trunk/core/src/main/java/org/apache/james/mime4=
j/message/StringTextBody.java
>>>> URL: http://svn.apache.org/viewvc/james/mime4j/trunk/core/src/main/jav=
a/org/apache/james/mime4j/message/StringTextBody.java?rev=3D778453&r1=3D778=
452&r2=3D778453&view=3Ddiff
>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
>>>> --- james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/mess=
age/StringTextBody.java (original)
>>>> +++ james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/mess=
age/StringTextBody.java Mon May 25 17:02:25 2009
>>>> @@ -19,7 +19,9 @@
>>>>
>>>> =C2=A0package org.apache.james.mime4j.message;
>>>>
>>>> +import java.io.ByteArrayInputStream;
>>>> =C2=A0import java.io.IOException;
>>>> +import java.io.InputStream;
>>>> =C2=A0import java.io.OutputStream;
>>>> =C2=A0import java.io.OutputStreamWriter;
>>>> =C2=A0import java.io.Reader;
>>>> @@ -48,6 +50,11 @@
>>>> =C2=A0 =C2=A0 =C2=A0}
>>>>
>>>> =C2=A0 =C2=A0 =C2=A0@Override
>>>> + =C2=A0 =C2=A0public InputStream getInputStream() throws IOException =
{
>>>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0return new ByteArrayInputStream(text.getB=
ytes(charset));
>>>> + =C2=A0 =C2=A0}
>>> String.getBytes(Charset) is a java6 only method.
>>>
>>> Hudson failed since this commit.
>>>
>>> I just replaced charset with charset.name(), please review as I don't
>>> know that code. Hudson now passes.
>>
>> Looks good, thanks!
>>
>> Could we configure Hudson to send build reports to this list?
>> Preferably only in case of failed builds..
>
> I'm not sure how Hudson notification works. Currently it was configured
> to send notifications to me. Sometimes I got failures, sometimes
> success, sometimes multiple messages.
>
> BTW, I just reconfigured mime4j to include this list address as a
> notification address, too.

TY

> Let's see if it works (probably we'll have to
> allow the hudson users on this list on the first message).

No problem..

> I also noticed that mime4j automatically publishes snapshots to
> https://repository.apache.org/content/repositories/snapshots/org/apache/j=
ames/
> I find this really useful for letting bug reporters test snapshots once
> we fix bugs.
>
>> I don't think I have a Hudson account. Could someone jump in?
>
> I don't think I can create hudson account anymore. Sudo access has been
> limited since I had my account. Try the JIRA way as Robert proposed.

Since you included the list address I don't need an account right
away. I'll file a JIRA if I ever need one again..

Thanks,
Markus