Mailing-List: contact mime4j-dev-help@james.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mime4j-dev@james.apache.org
Message-ID: <835744407.1244728387847.JavaMail.jira@brutus>
Date: Thu, 11 Jun 2009 06:53:07 -0700 (PDT)
From: "Markus Wiederkehr (JIRA)" <mime4j-dev@james.apache.org>
To: mime4j-dev@james.apache.org
Subject: [jira] Commented: (MIME4J-137) Rewrite MimeIOException eliminate
 unecessary MimeException and provide general constructors
In-Reply-To: <179780491.1244428807711.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MIME4J-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718462#action_12718462 ] 

Markus Wiederkehr commented on MIME4J-137:
------------------------------------------

There is something else to consider: LineReaderInputStream is an "input stream capable of reading lines of text" according to its contract. This means it should be oblivious to the MIME message format.

So MaxLineLimitException should extend neither MimeException nor MimeIOException in my opinion. Instead it should be either an independent exception class or a subclass of IOException. I would prefer the latter.

But if a maximum line length limit gets exceeded in a MIME message it should still be signaled as a MimeException. So the MaxLineLimitException has to be converted into a MimeException in AbstractEntity.fillFieldBuffer() (which is the only place where readLine() gets called).

> Rewrite MimeIOException eliminate unecessary MimeException and provide general constructors
> -------------------------------------------------------------------------------------------
>
>                 Key: MIME4J-137
>                 URL: https://issues.apache.org/jira/browse/MIME4J-137
>             Project: JAMES Mime4j
>          Issue Type: Improvement
>    Affects Versions: 0.6
>            Reporter: Nathan Beyer
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: mime4j-137.patch, MimeIOException.patch
>
>
> Rewrite the MimeIOException class to eliminate the hidden construction of a MimeException and provide a more conventional set of constructors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.