From mime4j-dev-return-514-apmail-james-mime4j-dev-archive=james.apache.org@james.apache.org Mon Jun 08 14:16:25 2009 Return-Path: Delivered-To: apmail-james-mime4j-dev-archive@minotaur.apache.org Received: (qmail 21541 invoked from network); 8 Jun 2009 14:16:25 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 8 Jun 2009 14:16:25 -0000 Received: (qmail 32483 invoked by uid 500); 8 Jun 2009 14:16:37 -0000 Delivered-To: apmail-james-mime4j-dev-archive@james.apache.org Received: (qmail 32454 invoked by uid 500); 8 Jun 2009 14:16:37 -0000 Mailing-List: contact mime4j-dev-help@james.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mime4j-dev@james.apache.org Delivered-To: mailing list mime4j-dev@james.apache.org Received: (qmail 32444 invoked by uid 99); 8 Jun 2009 14:16:37 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Jun 2009 14:16:37 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Jun 2009 14:16:34 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 006CD234C004 for ; Mon, 8 Jun 2009 07:16:12 -0700 (PDT) Message-ID: <1213756451.1244470572994.JavaMail.jira@brutus> Date: Mon, 8 Jun 2009 07:16:12 -0700 (PDT) From: "Markus Wiederkehr (JIRA)" To: mime4j-dev@james.apache.org Subject: [jira] Commented: (MIME4J-137) Rewrite MimeIOException eliminate unecessary MimeException and provide general constructors In-Reply-To: <179780491.1244428807711.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/MIME4J-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717262#action_12717262 ] Markus Wiederkehr commented on MIME4J-137: ------------------------------------------ IIRC MimeIOException was specifically designed to be an adapter class that converts a MimeException into an IOException (see MIME4J-77). As a consequence it should be safe to assume that a MimeIOException always has a cause that is a MimeException. Because of this I am not very happy with changing MimeIOException(MimeException) into MimeIOException(Throwable). I'm indifferent about the other constructor MimeIOException(String). The stack trace may become more readable but on the other hand the MimeIOException no longer has a cause that is a MimeException. Other opinions? > Rewrite MimeIOException eliminate unecessary MimeException and provide general constructors > ------------------------------------------------------------------------------------------- > > Key: MIME4J-137 > URL: https://issues.apache.org/jira/browse/MIME4J-137 > Project: JAMES Mime4j > Issue Type: Improvement > Affects Versions: 0.6 > Reporter: Nathan Beyer > Priority: Minor > Fix For: 0.7 > > Attachments: MimeIOException.patch > > > Rewrite the MimeIOException class to eliminate the hidden construction of a MimeException and provide a more conventional set of constructors. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.