james-mime4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Markus Wiederkehr (JIRA)" <mime4j-...@james.apache.org>
Subject [jira] Commented: (MIME4J-137) Rewrite MimeIOException eliminate unecessary MimeException and provide general constructors
Date Thu, 11 Jun 2009 13:53:07 GMT

    [ https://issues.apache.org/jira/browse/MIME4J-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718462#action_12718462

Markus Wiederkehr commented on MIME4J-137:

There is something else to consider: LineReaderInputStream is an "input stream capable of
reading lines of text" according to its contract. This means it should be oblivious to the
MIME message format.

So MaxLineLimitException should extend neither MimeException nor MimeIOException in my opinion.
Instead it should be either an independent exception class or a subclass of IOException. I
would prefer the latter.

But if a maximum line length limit gets exceeded in a MIME message it should still be signaled
as a MimeException. So the MaxLineLimitException has to be converted into a MimeException
in AbstractEntity.fillFieldBuffer() (which is the only place where readLine() gets called).

> Rewrite MimeIOException eliminate unecessary MimeException and provide general constructors
> -------------------------------------------------------------------------------------------
>                 Key: MIME4J-137
>                 URL: https://issues.apache.org/jira/browse/MIME4J-137
>             Project: JAMES Mime4j
>          Issue Type: Improvement
>    Affects Versions: 0.6
>            Reporter: Nathan Beyer
>            Priority: Minor
>             Fix For: 0.7
>         Attachments: mime4j-137.patch, MimeIOException.patch
> Rewrite the MimeIOException class to eliminate the hidden construction of a MimeException
and provide a more conventional set of constructors.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message