james-mime4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nathan Beyer (JIRA)" <mime4j-...@james.apache.org>
Subject [jira] Commented: (MIME4J-137) Rewrite MimeIOException eliminate unecessary MimeException and provide general constructors
Date Wed, 10 Jun 2009 01:31:07 GMT

    [ https://issues.apache.org/jira/browse/MIME4J-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717884#action_12717884
] 

Nathan Beyer commented on MIME4J-137:
-------------------------------------

Oleg, 
What would be the use case for catching a MimeIOException and then throwing MimeException?
There's no code in Mime4J that does this. As an app consumer, I found that there's no difference
in the exceptions - they are both Mime4J and I treat them exactly the same.

Is there any objection to making this change?

Index: src/main/java/org/apache/james/mime4j/MimeIOException.java
===================================================================
--- src/main/java/org/apache/james/mime4j/MimeIOException.java (revision 782498)
+++ src/main/java/org/apache/james/mime4j/MimeIOException.java (working copy)
@@ -34,7 +34,7 @@
      * @param message detail message.
      */
     public MimeIOException(String message) {
- this(new MimeException(message));
+ super(message);
     }
 
     /** 

> Rewrite MimeIOException eliminate unecessary MimeException and provide general constructors
> -------------------------------------------------------------------------------------------
>
>                 Key: MIME4J-137
>                 URL: https://issues.apache.org/jira/browse/MIME4J-137
>             Project: JAMES Mime4j
>          Issue Type: Improvement
>    Affects Versions: 0.6
>            Reporter: Nathan Beyer
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: MimeIOException.patch
>
>
> Rewrite the MimeIOException class to eliminate the hidden construction of a MimeException
and provide a more conventional set of constructors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message