james-mime4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Markus Wiederkehr <markus.wiederk...@gmail.com>
Subject Re: svn commit: r739871 - /james/mime4j/trunk/pom.xml
Date Sun, 01 Feb 2009 23:13:36 GMT
How about excluding the javacc stuff?

          <excludeRoots>
            <excludeRoot>target/generated-sources</excludeRoot>
          </excludeRoots>

Also I think that the controversial ruleset is really that:
controversial.. It spams the report and hides the really important
issues..

Markus



On Sun, Feb 1, 2009 at 11:24 PM,  <rdonkin@apache.org> wrote:
> Author: rdonkin
> Date: Sun Feb  1 22:24:22 2009
> New Revision: 739871
>
> URL: http://svn.apache.org/viewvc?rev=739871&view=rev
> Log:
> Switch PMD to use 1.5
>
> Modified:
>    james/mime4j/trunk/pom.xml
>
> Modified: james/mime4j/trunk/pom.xml
> URL: http://svn.apache.org/viewvc/james/mime4j/trunk/pom.xml?rev=739871&r1=739870&r2=739871&view=diff
> ==============================================================================
> --- james/mime4j/trunk/pom.xml (original)
> +++ james/mime4j/trunk/pom.xml Sun Feb  1 22:24:22 2009
> @@ -89,8 +89,8 @@
>         <artifactId>maven-compiler-plugin</artifactId>
>         <version>2.0.2</version>
>         <configuration>
> -          <source>1.5</source>
> -          <target>1.5</target>
> +          <source>${compileSource}</source>
> +          <target>${compileSource}</target>
>           <encoding>iso8859-1</encoding>
>         </configuration>
>       </plugin>
> @@ -310,7 +310,7 @@
>         <artifactId>maven-pmd-plugin</artifactId>
>         <version>2.4</version>
>         <configuration>
> -          <targetjdk>1.4</targetjdk>
> +          <targetJdk>${compileSource}</targetJdk>
>           <rulesets>
>             <ruleset>/rulesets/basic.xml</ruleset>
>             <ruleset>/rulesets/controversial.xml</ruleset>
> @@ -376,5 +376,8 @@
>             <archive>http://mail-archives.apache.org/mod_mbox/james-server-dev/</archive>
>     </mailingList>
>   </mailingLists>
> -
> +
> +  <properties>
> +    <compileSource>1.5</compileSource>
> +  </properties>
>  </project>
>
>
>



-- 
Always remember you're unique. Just like everyone else.

Mime
View raw message