Return-Path: Delivered-To: apmail-james-mime4j-dev-archive@minotaur.apache.org Received: (qmail 42982 invoked from network); 30 Jan 2009 16:45:26 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 30 Jan 2009 16:45:26 -0000 Received: (qmail 63877 invoked by uid 500); 30 Jan 2009 16:45:26 -0000 Delivered-To: apmail-james-mime4j-dev-archive@james.apache.org Received: (qmail 63855 invoked by uid 500); 30 Jan 2009 16:45:26 -0000 Mailing-List: contact mime4j-dev-help@james.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mime4j-dev@james.apache.org Delivered-To: mailing list mime4j-dev@james.apache.org Received: (qmail 63844 invoked by uid 99); 30 Jan 2009 16:45:26 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Jan 2009 08:45:26 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Jan 2009 16:45:20 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id CEA93234C4AC for ; Fri, 30 Jan 2009 08:44:59 -0800 (PST) Message-ID: <398911959.1233333899831.JavaMail.jira@brutus> Date: Fri, 30 Jan 2009 08:44:59 -0800 (PST) From: "Markus Wiederkehr (JIRA)" To: mime4j-dev@james.apache.org Subject: [jira] Updated: (MIME4J-93) The use of RootInputStream degrades performance by 50% MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/MIME4J-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Markus Wiederkehr updated MIME4J-93: ------------------------------------ Attachment: mime4j-optional-linenumbers-part1.patch This patch renames RootInputStream in LineNumberInputStream and also makes it optional. The patch does not handle the stream truncation. There is a FIXME in MimeTokenStream.stop().. Strangely the unit tests pass nevertheless. @Oleg: can you take over from here? I'm not sure how you wanted to handle the stream truncation.. > The use of RootInputStream degrades performance by 50% > ------------------------------------------------------ > > Key: MIME4J-93 > URL: https://issues.apache.org/jira/browse/MIME4J-93 > Project: JAMES Mime4j > Issue Type: Improvement > Affects Versions: 0.5 > Reporter: Oleg Kalnichevski > Fix For: 0.6 > > Attachments: mime4j-optional-linenumbers-part1.patch > > > I have never been a big fan of RootInputStream, because it simply does not work correctly for messages with binary coded parts. Please consider making RootInputStream optional, so one could eliminate it from the input filer chain entirely or disable line counting. This should result in a noticeable performance boost (up to 50%) > Oleg -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.