jakarta-taglibs-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 46086] javax.servlet.jsp.jstl.sql.ResultSupport.java silently swallows SQLException
Date Mon, 03 Nov 2008 23:34:18 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=46086





--- Comment #1 from Henri Yandell <bayard@apache.org>  2008-11-03 15:34:17 PST ---
*grumble*

Easiest fix - throw SQLException from those methods. Can't - it's in the spec.
Plus it would be a bit of a back compat surprise.

Next - create a new file - can't this is spec land. 

Next - use src/org/apache/taglibs/standard/tag/common/sql/ResultImpl.java
directly rather than ResultSupport. Of course - that means people aren't using
the spec anymore even if it is the same class (or copy of that class). Still -
worth doing I think, so I've made that commit.

Next is your RuntimeException, but that's another back compat surprise for
people. 

Here's my change:

svn ci -m "Adding constructors to ResultImpl to work around the SQLException
hiding in ResultSupport - and noted this in ResultSupport as per #46086" src

Sending        src/javax/servlet/jsp/jstl/sql/ResultSupport.java
Sending        src/org/apache/taglibs/standard/tag/common/sql/ResultImpl.java
Transmitting file data ..
Committed revision 711123 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=711123 ).


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: taglibs-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: taglibs-dev-help@jakarta.apache.org


Mime
View raw message