jakarta-taglibs-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "knlyknly" <knlyk...@sina.com>
Subject A suggestion about jakarta-taglibs-standard-1.1.2-src
Date Wed, 12 Mar 2008 11:46:30 GMT
I've downloaded jakarta-taglibs-standard-1.1.2-src.tar.gz 
2008.3.12

in the file
/jakarta-taglibs-standard-1.1.2-src/standard/src/org/apache/taglibs/standard/tag/common/sql/QueryTagSupport.java
Line 276-278:
    throw new JspException(Resources.getMessage("DATASOURCE_INVALID",ex.toString()));
and I think
    throw new JspException(Resources.getMessage("DATASOURCE_INVALID",ex.toString()),ex);
would be better for users who want to get the cause exception instead of only a message.

And how about
    if(ex instanceof SQLException)
        throw (SQLException)ex;
    else
        throw new JspException(Resources.getMessage("DATASOURCE_INVALID",ex.toString()),ex);
Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message