jakarta-taglibs-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Yandell" <flame...@gmail.com>
Subject Re: [standard] More bugs to resolve - thoughts?
Date Fri, 28 Sep 2007 04:39:14 GMT
On 8/24/07, Kris Schneider <kris@directthought.com> wrote:
> On 8/24/07, Henri Yandell <flamefew@gmail.com> wrote:
> > I've been churning on with my patch to add a caching SPI to Standard.
> > Here's the state, and what I think we should do:
> >
> > 17700 - Ostensibly this is a complaint that there is no caching in the
> > i18n stuff. When you dig deeper, it doesn't make sense as the poster
> > is complaining that the Resources class that handles errors for
> > Standard is the one that needs caching, and he refers to
> > ResourceMessages which does not exist. Too confusing, so WONTFIX.
> >
> > 31789 - Memory leak in ELEvaluator. This is the big issue - EL bits
> > are never GC'd it seems and it grows and grows until things OOM. This
> > is because caching is done. I've not tested this, though all I'm
> > adding is the ability to plug your own cache in, or choose between
> > forever caching or no caching.
> >
> > It's open source. If someone feels this problem strongly enough, it's
> > not hard to go in and change it so it uses a LRUCache or something.
> > So WONTFIX.
>
> At one point, there was a fairly healthy discussion about this:
>
> http://marc.info/?t=109820705200001
>
> Unfortunately, it seemed to just die rather abruptly. Since we're
> focusing on JSTL 1.1, I'd want to go back and review the code to see
> what's what. Based on my schedule, I won't be able to do that for
> another week.
>
> At the very least, I think we should expose ELEvaluator.mBypassCache
> via configuration and then actually honor it if it's set to false. I
> believe the current code skips the cache lookup when it's false but
> still caches the evaluation results - that seems like a bug (except
> that the code comments seem to imply that was the desired behavior).

What do you think to the latest commit Kris? Is Justyna's unreleased
1.0.x fix good enough for us to use for 1.1.3?

Hen

---------------------------------------------------------------------
To unsubscribe, e-mail: taglibs-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: taglibs-dev-help@jakarta.apache.org


Mime
View raw message