jakarta-taglibs-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 33934] - [standard] memory leak in jstl c:set tag
Date Fri, 07 Sep 2007 14:44:03 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=33934>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33934





------- Additional Comments From bayard@apache.org  2007-09-07 07:44 -------

Looking at SetSupport, its init() already sets target and property to null:

    private void init() {
        value = target = property = var = null;
        scopeSpecified = valueSpecified = false;
        scope = PageContext.PAGE_SCOPE;
    }

Looking at the JSTL LoopTagSupport, its init() sets item to null.

So the easy part of Kris' comment is already taken care of. 

Andreas points out that the attributes themselves are handled by target_,
property_ etc in the EL SetTag and suggests the transient target, property etc
could be released. They're not in the RT SetTag though, so I presume we can't
release them in the support class.

ie) Andreas' suggested change is the addition of a doEndTag method to EL SetTag
and (presumably as it's simplest) a call to init() from it.

Looking at the EL ForEachTag, the same could be done there.

Kris - is that still going to be against the spec?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: taglibs-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: taglibs-dev-help@jakarta.apache.org


Mime
View raw message