Mailing-List: contact taglibs-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tag Libraries Developers List" <taglibs-dev@jakarta.apache.org>
Received-SPF: pass (hermes.apache.org: domain of akolkar@us.ibm.com designates
 32.97.182.144 as permitted sender)
In-Reply-To: 
 <OFD6319EA4.764CDE4A-ON80256FF8.005DE9A8-80256FF8.005FD189@kissint.co.uk>
To: "Tag Libraries Developers List" <taglibs-dev@jakarta.apache.org>
MIME-Version: 1.0
Subject: Re: New version of Mailer tag
Message-ID: 
 <OFF71A2D6C.A925511F-ON85256FF8.0060CF4A-85256FF8.00619573@us.ibm.com>
From: Rahul P Akolkar <akolkar@us.ibm.com>
Date: Thu, 5 May 2005 13:45:51 -0400
Content-Type: multipart/alternative;
 boundary="=_alternative 0061957185256FF8_="

--=_alternative 0061957185256FF8_=
Content-Type: text/plain; charset="US-ASCII"

Hi Pete,

Based on your description, I would recommend making two separate 
enhancement requests in bugzilla [ http://jakarta.apache.org/taglibs/#Bugs 
]. You should also attach the relevant patches you authored with those 
requests. Also, based on the pre-requisite that you're convinced some tag 
was designed to work with pooling and it does not, then you may also 
report a separate bug for that issue.

After that, the appropriate person [maybe one of the folks listed at the 
bottom of this page- 
http://jakarta.apache.org/taglibs/doc/mailer-doc/intro.html ] will 
probably respond.

Thanks!
-Rahul


On 5/5/05, pete.storey@kisstechnologies.co.uk 
<pete.storey@kisstechnologies.co.uk> wrote:
> Hi,
> having been using the Mailer taglib for some while to send out all the
> emails from our sites and it has become obvious that there are a number 
of
> limitations and problems with it, specifically:
> 
> - You cannot produce a multi-part plain text and HTML email.  This means
> you can send decent mails and help them get through spam filters by
> avoiding obvious problems (eg HTML only mails).[Feature]
> - Attaching files seems to conflict with Tomcat's tag pooling, so if you
> attach a file then every time the tag is run, the file is attached an
> extra time to the email, thus by say the 5th run of it, there are 5
> attachments of the same file. [Bug]
> - You cannot set the filename of a file you attach to an arbitrary one.
> This means if you are attaching from a URL say with some parameters, you
> get a pretty nasty filename. [Feature]
> 
> To this end, I have written the necessary code to achieve the features 
and
> fix the bug.  It has meant changing MailTag, MessageTag, AttachTag and
> SendTag, as well as adding an attribute to the taglib.tld for the
> AttachTag (called filename).  The new version works exactly the same as
> before but you can now put one or two message tags within the body of 
the
> mail tag:
> 
> <mailer:mail server="localhost">
> 
>        <mailer:setrecipient type="to">a@b.com</mailer:setrecipient>
>        <mailer:from>a@b.com</mailer:from>
>        <mailer:subject>Subject</mailer:subject>
> 
>        <mailer:message type="text">
> 
> This is a test email message.
> 
>        </mailer:message>
> 
>        <mailer:message type="html">
> 
> <html>
> <body>
> <p>This is a test email message.</p>
> </body>
> </html>
> 
>        </mailer:message>
> 
>        <mailer:attach url="" filename="yourfile.html">
>                http://localhost/getmyfiletosend.html?fileId=123
>        </mailer:attach>
> 
>        <mailer:send/>
> 
> </mailer:mail>
> 
> What I don't know is how to contribute these features.  Anyone got any
> help here or can someone do it for me?  I guess it's really a new point
> version rather than a patch, though it is of course backwards 
compatible.
> 
> cheers
> Pete
> 
> Kiss Technologies
> 
> http://www.kisstechnologies.co.uk/
> 
> ** Please note, we have moved! **
> 131/132 High Holborn
> London
> WC1V 6PU
> 
> Phone numbers:
> 
> Phone 020 7692 9922
> Fax 020 7692 9923
> Out of hours
> Support phone 020 7692 9933
> 

--=_alternative 0061957185256FF8_=--