jakarta-taglibs-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kris Schneider <k...@dotech.com>
Subject Re: Memory Leak in ELEvaluator.java (standard v1.0.6)
Date Wed, 20 Oct 2004 17:55:34 GMT
Heh, my reading comprehension skills are failing. JSP 1.2 requires J2SE 1.2 and
JSP 2.0 requires J2SE 1.3.

Just to clarify Option #2, we're talking about taking the source code for
org.apache.commons.collections.map.LRUMap, changing its package, and resolving
all its dependencies by doing the same thing with the source code for those
classes and interfaces, right? If so, that seems reasonable. It would be nice
to be able to script that somehow...

In addition to the use of LRUMap, did anyone want to offer an opinion on
exposing a mechanism to configure the cache size (setting cache size = 0 would
effectively bypass caching)?  Personally, I think it's a good idea. In keeping
with the mechanics of the Config class, how about defining a servlet context
init param? Something like:

<context-param>
  <param-name>org.apache.taglibs.standard.lang.jstl.exprCacheSize</param-name>
  <param-value>100</param-value>
</context-param>

Any thoughts on using different caching strategies? How about leveraging
reference objects (SoftReference might be appropriate)?

Quoting Justyna Horwat <Justyna.Horwat@Sun.COM>:

> After sending my original mail yesterday I had looked at the JSP 2.0 
> requirements and you're right, they don't require J2SE 1.4.
> 
> Out of the options I like Option #2 the best as well for the same 
> reasons as Daryl and Felipe mentioned. I looked at the Collections 
> source and they list the JDK dependency as JDK 1.2 or later.
> 
> If support of the Collections classes becomes an issue we can revisit 
> this decision and always decide to add the jar dependency in the future.
> 
> Unless there are any objections, I'm going to go ahead with Option #2 
> and add the Collections LRUMap classes and dependencies into JSTL both 
> 1.0 and 1.1.
> 
> Thanks,
> 
> Justyna
> 
> Felipe Leme wrote:
> 
> > On Wed, 2004-10-20 at 01:04, Kris Schneider wrote:
> > 
> >>I think I jumped to the conclusion that Daryl was using JSTL 1.1 and 
> >>hence made the JSP 2.0 -> J2EE 1.4 -> J2SE 1.4 connections. 
> > 
> > 
> > And even JSP 2.0 doesn't require J2SE 1.4, when running inside a
> > 'standalone' web-container (i.e, outside a J2EE 1.4 container).
> > 
> > 
> >>required to support J2SE 1.3. I'm not sure I like taking on the 
> >>dependency, but the Collections project already contains the classes 
> > 
> > 
> > I thought about the Collections too, but then Standard would be compound
> > of 3 jars, which would certainly cause a lot of trouble, as people is
> > used to only copying jstl.jar and standard.jar. We have alternatives,
> > too:
> > 
> > - merge commons-collection.jar into standard.jar
> > - replicate the necessary classes into Standard src code
> > 
> > 
> > 
> >>org.apache.commons.collections.LRUMap (v.2.1.1) and 
> >>org.apache.commons.collections.map.LRUMap (v.3.1). I can't seem to put a 
> >>finger on the J2SE requirements for Collections though...
> > 
> > 
> > 
> > Assuming these classes doesn't have deep dependencies on others, I would
> > say the second option would be better (in the worst case, we would do
> > some minor changes in the classes, like removing calls to Commons
> > Logging, if any).
> > 
> > -- Felipe

-- 
Kris Schneider <mailto:kris@dotech.com>
D.O.Tech       <http://www.dotech.com/>

---------------------------------------------------------------------
To unsubscribe, e-mail: taglibs-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: taglibs-dev-help@jakarta.apache.org


Mime
View raw message