jakarta-taglibs-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pierre Delisle <pierre.deli...@sun.com>
Subject Re: [PATCH] io:http - can't invoke POST
Date Fri, 01 Nov 2002 18:30:51 GMT
Vladimir just submitted a patch for the io taglib.
I was just about to send a reply asking him to submit 
a bug report so it doesn't fall through the cracks
and gets logged officially (+ owner of taglib receives
a notification), but I just realized that he did exactly
what we preach in our home page under section
"Getting Involved - Patch Submission".

We may therefore want to clarify the text there to say
that patches sent to taglibs-dev should be for new
contributions, and that patches for bug fixes should be 
submitted via a bug report.

Makes sense?

If it does, Vladimir, would be great if you could submit
your patch via a bug report.

Thanks,

    -- Pierre


÷ÌÁÄÉÍÉÒ îÉËÉÔÉÎ wrote:
> 
> Hi.
> 
> This patch eliminates bug in HTTP tag IO tag library. The bug appears then
> one set attribute ACTION tag HTTP to POST. Tag HTTP doesn't invoke method
> POST instead of it invokes method GET. After applying this patch tag HTTP
> can invoke method POST.
> 
> With best regards Vladimir Nikitin.
> 
> patch:
> ----------------------------------------------------------------------------
> -------------------------------------------------
> 
> Index: HttpTag.java
> ===================================================================
> RCS file:
> /home/cvspublic/jakarta-taglibs/io/src/org/apache/taglibs/io/HttpTag.java,v
> retrieving revision 1.1
> diff -u -r1.1 HttpTag.java
> --- HttpTag.java 4 May 2001 18:08:09 -0000 1.1
> +++ HttpTag.java 1 Nov 2002 12:01:44 -0000
> @@ -105,11 +105,11 @@
> 
>      // Implementation methods
> 
> //-------------------------------------------------------------------------
> -    protected void configureConnection( HttpURLConnection connection )
> throws IOException {
> +    protected void configureConnection( URLConnection connection ) throws
> IOException {
>          super.configureConnection(connection);
> 
>          HttpURLConnection httpConnection = (HttpURLConnection) connection;
> -        connection.setRequestMethod( action );
> +        httpConnection.setRequestMethod( action );
>      }
> 
>      /** @return true if the given HTTP action should result in some
> 
> --
> To unsubscribe, e-mail:   <mailto:taglibs-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: <mailto:taglibs-dev-help@jakarta.apache.org>


--
To unsubscribe, e-mail:   <mailto:taglibs-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:taglibs-dev-help@jakarta.apache.org>


Mime
View raw message