jakarta-taglibs-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Petr Jiricka" <petr.jiri...@czech.sun.com>
Subject [Standard] [PATCH] Exception handling in JavascriptExpressionEvaluator
Date Mon, 03 Dec 2001 18:31:34 GMT
Hi JSR 52 coders,

now that the JspException class in JSP 1.2 allows specifying the root cause
throwable, would it make sense to propagate any exceptions caught in the
handlers code to JspException ?

See the patch below - that's just one occurrence of this pattern that I
randomly came across, but there may be other cases.

BTW, is this the right forum for the Standard taglib Reference
Implementation issues, or should I use some official JCP mechanism ?

Petr





cvs diff -u JavascriptExpressionEvaluator.java

Index: JavascriptExpressionEvaluator.java

===================================================================

RCS file:
/home/cvspublic/jakarta-taglibs/standard/src/org/apache/taglibs/standard/lan
g/javascript/JavascriptExpressionEvaluator.java,v

retrieving revision 1.3

diff -u -r1.3 JavascriptExpressionEvaluator.java

--- JavascriptExpressionEvaluator.java 2001/11/21 23:15:56 1.3

+++ JavascriptExpressionEvaluator.java 2001/12/03 18:05:48

@@ -126,7 +126,7 @@

result = new Boolean(result.toString());


} catch (JavaScriptException jse) {

- throw new JspException(jse.getMessage());

+ throw new JspException(jse.getMessage(), jse);

}


//System.out.println("RHINO result: " + result + ":");



--
To unsubscribe, e-mail:   <mailto:taglibs-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:taglibs-dev-help@jakarta.apache.org>


Mime
View raw message