jakarta-slide-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 37423] New: - retrieve branch in contentImpl does not work
Date Wed, 09 Nov 2005 11:55:45 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=37423>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37423

           Summary: retrieve branch in contentImpl does not work
           Product: Slide
           Version: Nightly
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: critical
          Priority: P1
         Component: Core
        AssignedTo: slide-dev@jakarta.apache.org
        ReportedBy: dho@oma.be


the method 

"public NodeRevisionDescriptor retrieve(SlideToken token, 
NodeRevisionDescriptors revisionDescriptors,String branch)"

does not work because it is incompatible with the NodeRevisionDescriptors 
instances returned by "public NodeRevisionDescriptors retrieve(SlideToken token, 
String uri)" (which is the only method to get a NodeRevisionDescriptors 
instance)

You can get 3 type of NodeRevisionDescriptors (based on uri and originalUri).

Case 1: retrive(token, "/files/some/versioned/resource"); // with resourceUri
  uri = /files/some/versioned/resource (uri redirector only redirect VersionUri)
  originalUri = /files/some/versioned/resource

Case 2: retrieve(token, "/history/1");     // with historyUri
  uri = /history/1
  originalUri = /history/1

Case 3: retrieve(token, "/history/1/1.1");   // with versionUri
  uri = /history/1
  originalUri = /history/1/1.0

In the case 2, method use version number "0.0" because originalUri is an 
historyUri
In the case 3, method use version number of the version because originalUri is a 
versionUri
In the case 1, method throw an exception because the "realRevisionDescriptors" 
(retrieved by the method at OriginalUri) is not versioned.

Then, there is no way to made this method doing what it should. 


A way to fix this is to remove the following line in DeltavUriRedirector.

            if( rUh.isHistoryUri() ) {
                result = NodeRevisionNumber.HIDDEN_0_0;
            }
but it can cause problem somewhere else.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org


Mime
View raw message