jakarta-slide-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pill, Juergen" <Juergen.P...@softwareag.com>
Subject RE: cvs commit: jakarta-slide/src/share/org/apache/slide/lock Loc kImpl.java
Date Wed, 12 Sep 2001 15:47:41 GMT
Hello,

following places use the enumerateLocks(...) method:

1) LockImpl.unlock
2) LockImpl.renew
3) LockImpl.kill
4) MacroImpl.deleteObject
5) WebdavServlet.displayDirectoryBrowsing
6) PropFind.parsePropertiesOfObject
7) LockMethod.executeRequest


Suggestion:

1) inherited == false
2) false
3) false
4) false
5) ? false ?
6) ? false ?
7) ? call LockImpl.renew ?

Could someone please verify 5-7 (possibly also 1-4). Did I miss something?

If no veto shows up, I will do the changes tomorrow.

Best regards

Juergen

-----Original Message-----
From: Christopher Lenz [mailto:cmlenz@gmx.de]
Sent: Wednesday, September 12, 2001 16.02 PM
To: slide-dev@jakarta.apache.org
Subject: RE: cvs commit: jakarta-slide/src/share/org/apache/slide/lock
Loc kImpl.java


12.09.2001 15:49:29, "Pill, Juergen" <Juergen.Pill@softwareag.com> wrote:

>why?
>
>I believe we have now following problem:
[snip]
>The delete method will now unlock the current URI, plus the father URI,
etc.

The change you reference simply made the Lock implementation work as it did 
before (you always got all the inherited locks from enumerateLocks()). If
this 
has introduced a problem, that problem must have existed before.

>This pattern occurs in multiple places:
[snip]
>Does this sound reasonable?

Yes. So if those are the only two places where we do not want to get the 
inherited locks in the Enumeration, we should use the new enumerateLocks() 
method there, with the 'inherited' parameter set to false.

>juergen
>
>
>
>
>
>
>
>-----Original Message-----
>From: cmlenz@apache.org [mailto:cmlenz@apache.org]
>Sent: Sunday, September 09, 2001 14.06 PM
>To: jakarta-slide-cvs@apache.org
>Subject: cvs commit: jakarta-slide/src/share/org/apache/slide/lock
>LockImpl.java
>
>
>cmlenz      01/09/09 05:05:57
>
>  Modified:    src/share/org/apache/slide/lock LockImpl.java
>  Log:
>  - enumerateLocks() without the 'inherited' parameter should pass 'true'
as
>    parameter value when calling enumerateLocks() with the 'inherited'
>    parameter
>  
>  Revision  Changes    Path
>  1.19      +5 -5
>jakarta-slide/src/share/org/apache/slide/lock/LockImpl.java
>  
>  Index: LockImpl.java
>  ===================================================================
>  RCS file:
>/home/cvs/jakarta-slide/src/share/org/apache/slide/lock/LockImpl.java,v
>  retrieving revision 1.18
>  retrieving revision 1.19
>  diff -u -r1.18 -r1.19
>  --- LockImpl.java	2001/09/08 19:50:37	1.18
>  +++ LockImpl.java	2001/09/09 12:05:57	1.19
>  @@ -1,7 +1,7 @@
>   /*
>  - * $Header:
>/home/cvs/jakarta-slide/src/share/org/apache/slide/lock/LockImpl.java,v
1.18
>2001/09/08 19:50:37 cmlenz Exp $
>  - * $Revision: 1.18 $
>  - * $Date: 2001/09/08 19:50:37 $
>  + * $Header:
>/home/cvs/jakarta-slide/src/share/org/apache/slide/lock/LockImpl.java,v
1.19
>2001/09/09 12:05:57 cmlenz Exp $
>  + * $Revision: 1.19 $
>  + * $Date: 2001/09/09 12:05:57 $
>    *
>    * ====================================================================
>    *
>  @@ -78,7 +78,7 @@
>    * Lock helper class.
>    * 
>    * @author <a href="mailto:remm@apache.org">Remy Maucherat</a>
>  - * @version $Revision: 1.18 $
>  + * @version $Revision: 1.19 $
>    */
>   public final class LockImpl implements Lock {
>       
>  @@ -310,7 +310,7 @@
>           throws ServiceAccessException, ObjectNotFoundException, 
>           LockTokenNotFoundException {
>           
>  -        return enumerateLocks(slideToken, objectUri, false);
>  +        return enumerateLocks(slideToken, objectUri, true);
>       }
>       
>       
>  
>  
>  
>
>

-chris
_______________________________________________
 /=/ cmlenz at gmx.de



Mime
View raw message