jakarta-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 48943] __StringFromFile() skips lines when used in combination with a Config Element
Date Wed, 07 Sep 2011 17:13:17 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=48943

--- Comment #3 from Philippe Mouawad <p.mouawad@ubik-ingenierie.com> 2011-09-07 17:13:17
UTC ---
Hello,
The issue occurs because ConfigTestElement ends up setting temporaryProperties
in AbstractTestElement#temporaryProperties which is not null anymore.


Then during the call of JMeterThread#notifyTestListeners, we end up
 calling recoverRunningVersion on each TestElement.
This method does this:
=> if (isTemporary(prop)) {
                iter.remove();
                clearTemporary(prop);
            }


isTemporary calls :
temporaryProperties.contains(property);

This one ends up calling FunctionProperty#hashCode which call super.hashCode => 
AbstractProperty#hashCode which call getStringValue() which 
 executes the BeanShell script again through this condition:
if (iter > testIteration || cacheValue == null) {
            testIteration = iter;
            cacheValue = function.execute();
        }

=> Which leads to the issue.
execute is called outside of Sampling.

So this issue could occur as long as setTemporary is called on
AbstractTestElement, so it is a big issue I think.



Now for the fix, I don't have the full code history, but I think that fix
should be in:
- hashCode 

I find it strange that equals and hashCode does not work on same datas.

Please find a patch but have a critical review of it.
I tested on submitted case and it works.

Regards
Philippe Mouawad

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org


Mime
View raw message