jakarta-jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Molettiere <pie...@sfinteractive.com>
Subject Re: Suggested UrlConfig Patch
Date Thu, 07 Jun 2001 19:01:20 GMT
"Stover, Michael" wrote:
> 
> > Maybe I'm not understanding something somewhere... maybe you
> > can point me in the right direction?
> 
> Latest CVS code, not yet released as a tar.


ok, I just downloaded, compiled, and ran the latest
CVS code, and I see that the protocol and port issue
has been fixed, but I don't see any code in UrlConfig
or HTTPSampler which handles query strings separate
from paths in the url...

just to be clear, I'm talking about

protocol://host/path?querystring

Are other people just constructing UrlConfig's 
with the query string appended to the path?

Am I the only one passing arguments to servlets using GET?

I'd propose something like this:

Index: UrlConfig.java
===================================================================
RCS file:
/home/cvspublic/jakarta-jmeter/src/org/apache/jmeter/protocol/http/config/UrlConfig.java,v
retrieving revision 1.9
diff -r1.9 UrlConfig.java
108c108
< 			return new URL(getProtocol(),getDomain(),getPath());
---
> 			return new URL(getProtocol(),getDomain(),getPath() + getQueryString() );
112c112
< 			return new URL(getProtocol(), (String)properties.get(DOMAIN),
getPort(), (String)properties.get(PATH));
---
> 			return new URL(getProtocol(), (String)properties.get(DOMAIN), getPort(), (String)properties.get(PATH)
+ getQueryString() );
177a178,192
> 	}
> 
> 	public void setQueryString(String qs) {
> 	    properties.put(QUERYSTRING, qs);
> 	}
> 
> 	public String getQueryString() {
> 	    String qs = (String) properties.get(QUERYSTRING);
> 	    if( qs == null || qs.equals("") ) {
> 		return "";
> 	    }
> 	    if( ! qs.startsWith("?") ) {
> 		qs = "?" + qs;
> 	    }
> 	    return qs;



Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


Mime
View raw message