jakarta-jcs-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron Smuts (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCS-50) 3 new memory caches
Date Mon, 08 Sep 2008 19:25:44 GMT

    [ https://issues.apache.org/jira/browse/JCS-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629265#action_12629265
] 

Aaron Smuts commented on JCS-50:
--------------------------------

I'm looking over this.  I guess we need a style guide.  All methods and variables meed javadocs.
 Not everything has them now but all new things need them.

I'm not sure why you would do this:

+        if ( value == null )
+        {
+            throw new NullPointerException();
+        }

Why nut just balk or throw and illegal argument exception.  I'd prefer doing nothing.  

There are a lot of changes to the core memory cache here.  It will take some time.

> 3 new memory caches
> -------------------
>
>                 Key: JCS-50
>                 URL: https://issues.apache.org/jira/browse/JCS-50
>             Project: JCS
>          Issue Type: Improvement
>          Components: Composite Cache
>    Affects Versions: jcs-1.4-dev
>         Environment: current jcs trunk
>            Reporter: Maxim Gordienko
>            Assignee: Aaron Smuts
>         Attachments: 0001-refactored-memory-cache-hierarchy.patch, 0002-improve-performance-or-MRU-list.patch,
0003-added-new-structure-PriorityList.patch, 0004-added-new-FIFO-memory-cache.patch, 0005-added-LFU-memory-cache.patch,
0006-added-Expiration-memory-cache.patch
>
>
> This is a refactoring/reformat of patch introduced in JCS-43.
> Patch is splitted in 6 parts
> 1) refactoring memory caches to achieve higher code reuse
> 2) refactoring MRU cache to use double linked list instead of LinkedList
> 3) introduction of new PriorityList structure
> 4-6) new caches FIFO, LFU, Expiration

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: jcs-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jcs-dev-help@jakarta.apache.org


Mime
View raw message